Patchwork [review] Silence ARI warning about floatformat_to_double

login
register
mail settings
Submitter Simon Marchi (Code Review)
Date Dec. 5, 2019, 3:44 p.m.
Message ID <gerrit.1575560698000.I778a17a04da417c113194004dd7de3b1df381266@gnutoolchain-gerrit.osci.io>
Download mbox | patch
Permalink /patch/36536/
State New
Headers show

Comments

Simon Marchi (Code Review) - Dec. 5, 2019, 3:44 p.m.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/745
......................................................................

Silence ARI warning about floatformat_to_double

This silences ARI at the one spot that is permitted to call
floatformat_to_double.

gdb/ChangeLog
2019-12-05  Tom Tromey  <tromey@adacore.com>

	* target-float.c (host_float_ops<T>::from_target): Add ARI
	comment.

Change-Id: I778a17a04da417c113194004dd7de3b1df381266
---
M gdb/ChangeLog
M gdb/target-float.c
2 files changed, 7 insertions(+), 2 deletions(-)
Simon Marchi (Code Review) - Dec. 5, 2019, 4:50 p.m.
Pedro Alves has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/745
......................................................................


Patch Set 1: Code-Review+2

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 36f407f..fe81ff8 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@ 
 2019-12-05  Tom Tromey  <tromey@adacore.com>
 
+	* target-float.c (host_float_ops<T>::from_target): Add ARI
+	comment.
+
+2019-12-05  Tom Tromey  <tromey@adacore.com>
+
 	* utils.c (abort_with_message, dump_core, internal_vproblem): Add
 	ARI marker to abort.
 	* event-top.c (handle_sigsegv): Add ARI marker to abort.
diff --git a/gdb/target-float.c b/gdb/target-float.c
index caa6943..ddf20c8 100644
--- a/gdb/target-float.c
+++ b/gdb/target-float.c
@@ -647,8 +647,8 @@ 
     {
       double dto;
 
-      floatformat_to_double (fmt->split_half ? fmt->split_half : fmt,
-			     from, &dto);
+      floatformat_to_double	/* ARI: floatformat_to_double */
+	(fmt->split_half ? fmt->split_half : fmt, from, &dto);
       *to = (T) dto;
       return;
     }