[review] Remove ATTRIBUTE_UNUSED check from ARI
Commit Message
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/742
......................................................................
Remove ATTRIBUTE_UNUSED check from ARI
The text for the ATTRIBUTE_UNUSED check in ARI is plainly incorrect
now -- gdb does in fact use ATTRIBUTE_UNUSED, and there's no issue in
doing so, when done properly.
This patch removes this check.
gdb/ChangeLog
2019-12-05 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
Change-Id: I13fd8e9b40dbaab3978dbf9b6c4228b62299d944
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 4 insertions(+), 11 deletions(-)
Comments
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/742
......................................................................
Patch Set 1: Code-Review+2
@@ -1,5 +1,9 @@
2019-12-05 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
+
+2019-12-05 Tom Tromey <tromey@adacore.com>
+
* contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
checks.
@@ -581,17 +581,6 @@
fail("long long")
}
-BEGIN { doc["ATTRIBUTE_UNUSED"] = "\
-Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, \
-consequently, is not able to tolerate false warnings. Since -Wunused-param \
-produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED \
-are used by GDB"
- category["ATTRIBUTE_UNUSED"] = ari_regression
-}
-/(^|[^_[:alnum:]])ATTRIBUTE_UNUSED([^_[:alnum:]]|$)/ {
- fail("ATTRIBUTE_UNUSED")
-}
-
BEGIN { doc["ATTR_FORMAT"] = "\
Do not use ATTR_FORMAT, use ATTRIBUTE_PRINTF instead"
category["ATTR_FORMAT"] = ari_regression