From patchwork Wed Dec 4 11:41:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 36499 Received: (qmail 50798 invoked by alias); 4 Dec 2019 11:41:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 50714 invoked by uid 89); 4 Dec 2019 11:41:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:cover.1 X-HELO: mail-wm1-f66.google.com Received: from mail-wm1-f66.google.com (HELO mail-wm1-f66.google.com) (209.85.128.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Dec 2019 11:41:21 +0000 Received: by mail-wm1-f66.google.com with SMTP id t14so7509978wmi.5 for ; Wed, 04 Dec 2019 03:41:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=S9K6V7agnShFs6Tzj26slEiw25u/sIlmlMInWOzccQo=; b=gIMrPg05XtT/CLyZwAf84nssCNkOcXUxgZgTGJgDSbQymocP+c+UaiSPfrLmJkBnY1 vJ6uMWit/Byy1A2SX0aEHV5+J5vocYL97WV5EnuUnxXLAi8aBJAwXcmHIuINnRCzNWYi PDpY3gi7tAxQJGa6zVD5p1Kljzo400KwBfkmJp4ehH2yJ0nsYKgaRcYyWKYnCqymbM9z rsvpvzmZ9iAXjwYgCMJyfFLiFosVQd17GsgcMufTT/v1WhM2ldMRhaqVsNJ7xj0Dp/rj 15kQmsht9t9PGbzXN3m9hxdt5lGozEZIGNS8SriRK0oEjYlDp8D+b2aYk8ac74FyunO3 VKNA== Return-Path: Received: from localhost (host109-151-46-117.range109-151.btcentralplus.com. [109.151.46.117]) by smtp.gmail.com with ESMTPSA id m8sm6684097wmf.8.2019.12.04.03.41.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Dec 2019 03:41:18 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 2/3] gdb/testsuite: kfail some tests if using broken gcc Date: Wed, 4 Dec 2019 11:41:13 +0000 Message-Id: <522e5bea7e02a2d67ad129fc838d3a38ce5e3e9d.1575457286.git.andrew.burgess@embecosm.com> In-Reply-To: References: In-Reply-To: References: X-IsSubscribed: yes In some cases the Fortran stride information generated by GCC is wrong with versions of GCC after 7.x.x. This commit adds kfails for the tests in question with known bad versions of gcc. The bug has been reported to GCC here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92775 gdb/testsuite/ChangeLog: * gdb.fortran/derived-type-striding.exp: KFAIL if we are using a broken version of GCC. Change-Id: Iaef08e5e2c87ab3d6983b88f749d40e01aea2bc6 --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.fortran/derived-type-striding.exp | 6 ++++++ 2 files changed, 11 insertions(+) diff --git a/gdb/testsuite/gdb.fortran/derived-type-striding.exp b/gdb/testsuite/gdb.fortran/derived-type-striding.exp index a2590a9ab2f..dc5ef96b3bc 100644 --- a/gdb/testsuite/gdb.fortran/derived-type-striding.exp +++ b/gdb/testsuite/gdb.fortran/derived-type-striding.exp @@ -20,6 +20,10 @@ if {[skip_fortran_tests]} { return -1 } standard_testfile ".f90" +# Unfortunately recent versions of GCC broke the stride information in +# the DEBUG so tests in this file will fail. +set gcc_with_broken_stride [test_compiler_info {gcc-[89]-*}] + if {[prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \ {debug f90}]} { return -1 @@ -31,7 +35,9 @@ if {![runto [gdb_get_line_number "post_init"]]} then { } # Test homogeneous derived type. +if { $gcc_with_broken_stride } { setup_kfail *-*-* gcc/92775 } gdb_test "p point_dimension" "= \\\(2, 2, 2, 2, 2, 2, 2, 2, 2\\\)" # Test mixed type derived type. +if { $gcc_with_broken_stride } { setup_kfail *-*-* gcc/92775 } gdb_test "p point_mixed_dimension" "= \\\(3, 3, 3, 3\\\)"