Patchwork [review] Use metadata style in a few more places

login
register
mail settings
Submitter Simon Marchi (Code Review)
Date Dec. 3, 2019, 12:20 a.m.
Message ID <gerrit.1575332417000.Id82ca2aa306c6694b111d5c92dfa6f0cce919ebf@gnutoolchain-gerrit.osci.io>
Download mbox | patch
Permalink /patch/36450/
State New
Headers show

Comments

Simon Marchi (Code Review) - Dec. 3, 2019, 12:20 a.m.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/739
......................................................................

Use metadata style in a few more places

I happened to find a few more spots that should use metadata style,
but do not.  I missed these in my earlier search somehow.  This patch
also adds gettext markup in a couple of spots where it was missing.

gdb/ChangeLog
2019-12-02  Tom Tromey  <tom@tromey.com>

	* valprint.c (val_print_string): Use metadata_style.
	* go-valprint.c (print_go_string): Use metadata style.
	* p-valprint.c (pascal_object_print_static_field): Use metadata
	style.
	* cp-valprint.c (cp_print_static_field): Use metadata style.

Change-Id: Id82ca2aa306c6694b111d5c92dfa6f0cce919ebf
---
M gdb/ChangeLog
M gdb/cp-valprint.c
M gdb/go-valprint.c
M gdb/p-valprint.c
M gdb/valprint.c
5 files changed, 24 insertions(+), 15 deletions(-)
Simon Marchi (Code Review) - Dec. 4, 2019, 10:50 a.m.
Andrew Burgess has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/739
......................................................................


Patch Set 1: Code-Review+2

LGTM.

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 59825d3..73c3c83 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,13 @@ 
 2019-12-02  Tom Tromey  <tom@tromey.com>
 
+	* valprint.c (val_print_string): Use metadata_style.
+	* go-valprint.c (print_go_string): Use metadata style.
+	* p-valprint.c (pascal_object_print_static_field): Use metadata
+	style.
+	* cp-valprint.c (cp_print_static_field): Use metadata style.
+
+2019-12-02  Tom Tromey  <tom@tromey.com>
+
 	* unittests/tui-selftests.c (run_tests): Make conditional.
 	(_initialize_tui_selftest): Make conditional.
 
diff --git a/gdb/cp-valprint.c b/gdb/cp-valprint.c
index e445d42..0ec84f6 100644
--- a/gdb/cp-valprint.c
+++ b/gdb/cp-valprint.c
@@ -638,9 +638,9 @@ 
 	{
 	  if (value_address (val) == first_dont_print[i])
 	    {
-	      fputs_filtered ("<same as static member of an already"
-			      " seen type>",
-			      stream);
+	      fputs_styled (_("<same as static member of an already"
+			      " seen type>"),
+			    metadata_style.style (), stream);
 	      return;
 	    }
 	}
@@ -670,9 +670,9 @@ 
 	{
 	  if (target_type == first_dont_print[i])
 	    {
-	      fputs_filtered ("<same as static member of an already"
-			      " seen type>",
-			      stream);
+	      fputs_styled (_("<same as static member of an already"
+			      " seen type>"),
+			    metadata_style.style (), stream);
 	      return;
 	    }
 	}
diff --git a/gdb/go-valprint.c b/gdb/go-valprint.c
index eda40f8..64761b9 100644
--- a/gdb/go-valprint.c
+++ b/gdb/go-valprint.c
@@ -29,6 +29,7 @@ 
 #include "go-lang.h"
 #include "c-lang.h"
 #include "valprint.h"
+#include "cli/cli-style.h"
 
 /* Print a Go string.
 
@@ -71,9 +72,9 @@ 
 
   if (length < 0)
     {
-      fputs_filtered (_("<invalid length: "), stream);
-      fputs_filtered (plongest (addr), stream);
-      fputs_filtered (">", stream);
+      printf_filtered (_("<invalid length: %ps>"),
+		       styled_string (metadata_style.style (),
+				      plongest (addr)));
       return;
     }
 
diff --git a/gdb/p-valprint.c b/gdb/p-valprint.c
index e1e1a00..198d6b6 100644
--- a/gdb/p-valprint.c
+++ b/gdb/p-valprint.c
@@ -865,9 +865,9 @@ 
 	{
 	  if (value_address (val) == first_dont_print[i])
 	    {
-	      fputs_filtered ("\
-<same as static member of an already seen type>",
-			      stream);
+	      fputs_styled (_("\
+<same as static member of an already seen type>"),
+			    metadata_style.style (), stream);
 	      return;
 	    }
 	}
diff --git a/gdb/valprint.c b/gdb/valprint.c
index ced0dbc..1e3071b 100644
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -2897,9 +2897,9 @@ 
     {
       std::string str = memory_error_message (TARGET_XFER_E_IO, gdbarch, addr);
 
-      fprintf_filtered (stream, "<error: ");
-      fputs_filtered (str.c_str (), stream);
-      fprintf_filtered (stream, ">");
+      fprintf_filtered (stream, _("<error: %ps>"),
+			styled_string (metadata_style.style (),
+				       str.c_str ()));
     }
 
   return (bytes_read / width);