Patchwork [FYI] Fix build breakage with --disable-tui

login
register
mail settings
Submitter Tom Tromey
Date Dec. 2, 2019, 11:13 p.m.
Message ID <20191202231327.8806-1-tom@tromey.com>
Download mbox | patch
Permalink /patch/36445/
State New
Headers show

Comments

Tom Tromey - Dec. 2, 2019, 11:13 p.m.
An earlier patch introduced a unit test for tui_copy_source_line.
However if the TUI is not built (as is apparently the case on some of
the buildbot builders), then this will fail to link.

This patch fixes the problem.  Tested by rebuilding with the TUI
disabled.

gdb/ChangeLog
2019-12-02  Tom Tromey  <tom@tromey.com>

	* unittests/tui-selftests.c (run_tests): Make conditional.
	(_initialize_tui_selftest): Make conditional.

Change-Id: I964811c7635be24cf6c53920e74e920914503674
---
 gdb/ChangeLog                 | 5 +++++
 gdb/unittests/tui-selftests.c | 6 ++++++
 2 files changed, 11 insertions(+)

Patch

diff --git a/gdb/unittests/tui-selftests.c b/gdb/unittests/tui-selftests.c
index 3a5d34fe48c..95c12e3f5d2 100644
--- a/gdb/unittests/tui-selftests.c
+++ b/gdb/unittests/tui-selftests.c
@@ -21,6 +21,8 @@ 
 #include "gdbsupport/selftest.h"
 #include "tui/tui-winsource.h"
 
+#ifdef TUI
+
 namespace selftests {
 namespace tui {
 
@@ -41,8 +43,12 @@  run_tests ()
 } /* namespace tui*/
 } /* namespace selftests */
 
+#endif /* TUI */
+
 void
 _initialize_tui_selftest ()
 {
+#ifdef TUI
   selftests::register_test ("tui", selftests::tui::run_tests);
+#endif
 }