Patchwork [pushed] Treat inactive TUI specially in "info win"

login
register
mail settings
Submitter Simon Marchi (Code Review)
Date Dec. 1, 2019, 8:28 p.m.
Message ID <20191201202807.60D6A2816F@gnutoolchain-gerrit.osci.io>
Download mbox | patch
Permalink /patch/36410/
State New
Headers show

Comments

Simon Marchi (Code Review) - Dec. 1, 2019, 8:28 p.m.
The original change was created by Tom Tromey.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/692
......................................................................

Treat inactive TUI specially in "info win"

I noticed that "info win" will print the table header, but no windows,
when the TUI is inactive.  This patch changes this to print a message
instead.

gdb/ChangeLog
2019-12-01  Tom Tromey  <tom@tromey.com>

	* tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
	specially.

Change-Id: Ia860be8c786a71289da6609aa14d86b8365424db
---
M gdb/ChangeLog
M gdb/tui/tui-win.c
2 files changed, 11 insertions(+), 0 deletions(-)

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e61b08b..497626d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@ 
 2019-12-01  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
+	specially.
+
+2019-12-01  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 	\0.
 	* unittests/tui-selftests.c: New file.
diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c
index b6204be..b0111d7 100644
--- a/gdb/tui/tui-win.c
+++ b/gdb/tui/tui-win.c
@@ -847,6 +847,12 @@ 
 static void
 tui_all_windows_info (const char *arg, int from_tty)
 {
+  if (!tui_active)
+    {
+      printf_filtered (_("The TUI is not active.\n"));
+      return;
+    }
+
   struct tui_win_info *win_with_focus = tui_win_with_focus ();
   struct ui_out *uiout = current_uiout;