From patchwork Thu Nov 28 17:23:58 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Joseph Myers <joseph@codesourcery.com>
X-Patchwork-Id: 36357
Received: (qmail 68818 invoked by alias); 28 Nov 2019 17:24:27 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 68716 invoked by uid 89); 28 Nov 2019 17:24:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-15.2 required=5.0 tests=AWL, BAYES_00,
	GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,
	SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:842,
	H*MI:sk:2019111
X-HELO: esa1.mentor.iphmx.com
IronPort-SDR: 
 EwmwqcJtJUXvuYAuaUEe7t9WRctC77a/qKZmh2cQfXsedNDMBS4IR+cdiPuRUZMjZYyokJ1o5j
	iruEmJbllhpxAyaYIo/GJFkShdlvfMeKSIA3zJ0+4Cf9jqhgUK90bIxdlTSGCh4Zxn1qmWsLMq
	HAS0kIzoeEakBxEg3YsDNSHNFj0mOzEHUriKP4hbBJg2ARQEncsnUostCMa2wyageLEXtHgJgF
	NSxEsifPiM98Kll/tr50Mz16KP/X20303ZyXL+oZyz9819kTT0jhGaiXjU7QwTCPQVQ6WshSuh
	23E=
IronPort-SDR: 
 zzN5opf1F3ffUet+njyrNlJMJ3bfz2MvlJFM6DYEWAtisCpIDd00sHPNi0T8/TYdqpUPwuFAnt
	yqUrgdcnOyQ8F6ZcjExLvzXbqDtkwimHHdN/VJk0ONKlDpJf6N+WjCfJZRF0/bJv/EUUgJFuDq
	MeeEpTal0LvvNNyfsCknNPhQzOjexqHnZz0MWztH4cuHZwNoy+MWzGSrwuL16Qn7zKLEq4lFEJ
	hpSTe3W1lshhT8l1KAPtBPrYfRVF4pAUgocF0+2RncR8WI8OkVwbSkrDz1nt5y66aAcHek6DlP
	who=
Date: Thu, 28 Nov 2019 17:23:58 +0000
From: Joseph Myers <joseph@codesourcery.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
CC: <libc-alpha@sourceware.org>, Romain Naour <romain.naour@smile.fr>,
	Andreas Larsson <andreas@gaisler.com>
Subject: Re: [PATCH 1/2] Remove 32 bit sparc v7 support
In-Reply-To: <ce40fa83-ac5a-a9b3-8ef1-79c3349754f3@linaro.org>
Message-ID: <alpine.DEB.2.21.1911281721200.3862@digraph.polyomino.org.uk>
References: <a9e59b02-66e4-e81b-e6ec-90b9cc99b045@linaro.org>
	<20191113192823.17109-1-adhemerval.zanella@linaro.org>
	<alpine.DEB.2.21.1911132031470.24245@digraph.polyomino.org.uk>
	<0266dcfa-f3bf-137b-1eac-c4c67e55e920@linaro.org>
	<ce40fa83-ac5a-a9b3-8ef1-79c3349754f3@linaro.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Return-Path: joseph@codesourcery.com

These changes have broken build-many-glibcs.py, fix committed:

Fix syntax error in build-many-glibcs.py.

The recent SPARC changes caused a syntax error:

    'ccopts': '-m32 -mlong-double-128 -mcpu=v9'}],
                                                ^
SyntaxError: invalid syntax

Fixed by this patch.

diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
index f4d66838b1..34c933acbc 100755
--- a/scripts/build-many-glibcs.py
+++ b/scripts/build-many-glibcs.py
@@ -359,7 +359,7 @@ class Context(object):
                         os_name='linux-gnu',
                         glibcs=[{},
                                 {'arch': 'sparcv8',
-                                 'ccopts': '-m32 -mlong-double-128 -mcpu=leon3'}],
+                                 'ccopts': '-m32 -mlong-double-128 -mcpu=leon3'},
                                 {'arch': 'sparcv9',
                                  'ccopts': '-m32 -mlong-double-128 -mcpu=v9'}],
                         extra_glibcs=[{'variant': 'disable-multi-arch',