Patchwork [1/2] Remove 32 bit sparc v7 support

login
register
mail settings
Submitter Joseph Myers
Date Nov. 28, 2019, 5:23 p.m.
Message ID <alpine.DEB.2.21.1911281721200.3862@digraph.polyomino.org.uk>
Download mbox | patch
Permalink /patch/36357/
State New
Headers show

Comments

Joseph Myers - Nov. 28, 2019, 5:23 p.m.
These changes have broken build-many-glibcs.py, fix committed:

Fix syntax error in build-many-glibcs.py.

The recent SPARC changes caused a syntax error:

    'ccopts': '-m32 -mlong-double-128 -mcpu=v9'}],
                                                ^
SyntaxError: invalid syntax

Fixed by this patch.
Joseph Myers - Nov. 28, 2019, 5:33 p.m.
On Thu, 28 Nov 2019, Joseph Myers wrote:

> These changes have broken build-many-glibcs.py, fix committed:
> 
> Fix syntax error in build-many-glibcs.py.
> 
> The recent SPARC changes caused a syntax error:
> 
>     'ccopts': '-m32 -mlong-double-128 -mcpu=v9'}],
>                                                 ^
> SyntaxError: invalid syntax
> 
> Fixed by this patch.

Also, while this fixes the syntax error, I don't think having the sparcv8 
entry listed in glibcs is correct.  That's for the glibcs built with the 
compilers; unless the GCC configuration for sparc64 is building the 
*three* multilibs listed there, the sparcv8 entry should be in 
extra_glibcs not glibcs.
Adhemerval Zanella Netto - Nov. 28, 2019, 7:29 p.m.
On 28/11/2019 14:33, Joseph Myers wrote:
> On Thu, 28 Nov 2019, Joseph Myers wrote:
> 
>> These changes have broken build-many-glibcs.py, fix committed:
>>
>> Fix syntax error in build-many-glibcs.py.
>>
>> The recent SPARC changes caused a syntax error:
>>
>>     'ccopts': '-m32 -mlong-double-128 -mcpu=v9'}],
>>                                                 ^
>> SyntaxError: invalid syntax
>>
>> Fixed by this patch.
> 
> Also, while this fixes the syntax error, I don't think having the sparcv8 
> entry listed in glibcs is correct.  That's for the glibcs built with the 
> compilers; unless the GCC configuration for sparc64 is building the 
> *three* multilibs listed there, the sparcv8 entry should be in 
> extra_glibcs not glibcs.
> 

Alright, I will sort this out.
Joseph Myers - Nov. 28, 2019, 8:10 p.m.
Also, the sparcv9-linux-gnu-disable-multi-arch configuration fails to 
build because of the new configure tests ("configure: error: no support 
for pre-v8 sparc").  I guess it needs to specify a CPU option explicitly 
now.

Patch

diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
index f4d66838b1..34c933acbc 100755
--- a/scripts/build-many-glibcs.py
+++ b/scripts/build-many-glibcs.py
@@ -359,7 +359,7 @@  class Context(object):
                         os_name='linux-gnu',
                         glibcs=[{},
                                 {'arch': 'sparcv8',
-                                 'ccopts': '-m32 -mlong-double-128 -mcpu=leon3'}],
+                                 'ccopts': '-m32 -mlong-double-128 -mcpu=leon3'},
                                 {'arch': 'sparcv9',
                                  'ccopts': '-m32 -mlong-double-128 -mcpu=v9'}],
                         extra_glibcs=[{'variant': 'disable-multi-arch',