From patchwork Tue Nov 26 22:15:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 36276 Received: (qmail 75754 invoked by alias); 26 Nov 2019 22:15:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 75746 invoked by uid 89); 26 Nov 2019 22:15:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=offending, HX-Languages-Length:1104, HContent-Transfer-Encoding:8bit X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Nov 2019 22:15:57 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 48788116B77; Tue, 26 Nov 2019 17:15:56 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id hioRgIAhlPz7; Tue, 26 Nov 2019 17:15:56 -0500 (EST) Received: from murgatroyd.Home (97-118-104-188.hlrn.qwest.net [97.118.104.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 048EA116B76; Tue, 26 Nov 2019 17:15:55 -0500 (EST) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [FYI] Fix mingw build of gdb Date: Tue, 26 Nov 2019 15:15:54 -0700 Message-Id: <20191126221554.20898-1-tromey@adacore.com> MIME-Version: 1.0 Christian pointed out on irc that the threading series broke the build on mingw. This patch fixes the problem, by moving the initialization of gdb_demangle_attempt_core_dump into the appropriate #if. gdb/ChangeLog 2019-11-26 Tom Tromey * cp-support.c (_initialize_cp_support): Conditionally initialize gdb_demangle_attempt_core_dump. Change-Id: I9ace0bea75a51f317ea933b607f6b5a94d651eea --- gdb/ChangeLog | 5 +++++ gdb/cp-support.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/cp-support.c b/gdb/cp-support.c index 4de2a98e87a..bec8dc86157 100644 --- a/gdb/cp-support.c +++ b/gdb/cp-support.c @@ -2199,6 +2199,8 @@ display the offending symbol."), NULL, &maintenance_set_cmdlist, &maintenance_show_cmdlist); + + gdb_demangle_attempt_core_dump = can_dump_core (LIMIT_CUR); #endif #if GDB_SELF_TEST @@ -2207,6 +2209,4 @@ display the offending symbol."), selftests::register_test ("cp_remove_params", selftests::test_cp_remove_params); #endif - - gdb_demangle_attempt_core_dump = can_dump_core (LIMIT_CUR); }