From patchwork Mon Nov 25 05:26:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 36176 Received: (qmail 50285 invoked by alias); 25 Nov 2019 05:27:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 50013 invoked by uid 89); 25 Nov 2019 05:27:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1246 X-HELO: mail.efficios.com Received: from mail.efficios.com (HELO mail.efficios.com) (167.114.142.138) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Nov 2019 05:27:25 +0000 Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id 85ED634757D for ; Mon, 25 Nov 2019 00:27:21 -0500 (EST) Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id KTmNFxDJRiH3; Mon, 25 Nov 2019 00:27:21 -0500 (EST) Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id 0EA3B347533; Mon, 25 Nov 2019 00:27:18 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 0EA3B347533 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1574659638; bh=pH97mlt6vsXeZaL/fjR4mDYDLHx3fYznUDRk+9QkDuA=; h=From:To:Date:Message-Id:MIME-Version; b=fNp/dQrat2097FCfj8XIOykaCRATP+CxZzspcot+Ixl6cnIzKp0nEwHoSfA2hMnAE 4OS5V15UwAsR7U1JZ3CQ3BQaIZIi8U37bShDzaYqb6GHKiS5+ZgCzE1Q2v163omSrj mIctgY3JgOY9nfy4axh3vXvRSFMPWyXQWJqSRgJlgpfErXN9OzK3CRpot6KhdEx7Cy 8/LTGCvPBiWAGUbPemy0uQr3OmwQhKXYUjyffdvzAceFyjYP1z2U+BODh2crizQk6G R6FlzRPM7shDoOg35hIcdFPxTu/E0Ii8S6+THr0U9HwhOM4GabLvvj0fOf3hs9ltR5 dJGm5oMTEl1AQ== Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id 2_9Mwdzc6_JQ; Mon, 25 Nov 2019 00:27:17 -0500 (EST) Received: from smarchi-efficios.lan (unknown [192.222.164.54]) by mail.efficios.com (Postfix) with ESMTPSA id 3AEC53474BF; Mon, 25 Nov 2019 00:27:12 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 15/15] Enable -Wmissing-declarations diagnostic Date: Mon, 25 Nov 2019 00:26:55 -0500 Message-Id: <20191125052655.22696-16-simon.marchi@efficios.com> In-Reply-To: <20191125052655.22696-1-simon.marchi@efficios.com> References: <20191125052655.22696-1-simon.marchi@efficios.com> MIME-Version: 1.0 Now that most warnings of this kind are fixed, we can enable -Wmissing-declarations. I say "most", because it is likely that there are some more in some configurations I am not able to build, but they should be pretty easy to fix. gdb/ChangeLog: * warning.m4: Add -Wmissing-declarations to build_warnings. * configure: Re-generate. Change-Id: Iae9b59f22eb5dd1965d09f34c5c9e212cddf67ba --- gdb/configure | 3 ++- gdb/warning.m4 | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/gdb/configure b/gdb/configure index 4afd7f9b9680..cf3aff66b4d0 100755 --- a/gdb/configure +++ b/gdb/configure @@ -15265,7 +15265,8 @@ build_warnings="-Wall -Wpointer-arith \ -Wshadow=local \ -Wdeprecated-copy \ -Wdeprecated-copy-dtor \ --Wredundant-move" +-Wredundant-move \ +-Wmissing-declarations" case "${host}" in *-*-mingw32*) diff --git a/gdb/warning.m4 b/gdb/warning.m4 index c9e64a1836a8..3162fe3a04a8 100644 --- a/gdb/warning.m4 +++ b/gdb/warning.m4 @@ -49,7 +49,8 @@ build_warnings="-Wall -Wpointer-arith \ -Wshadow=local \ -Wdeprecated-copy \ -Wdeprecated-copy-dtor \ --Wredundant-move" +-Wredundant-move \ +-Wmissing-declarations" case "${host}" in *-*-mingw32*)