Patchwork [review] Remove a call to update_exec_info

login
register
mail settings
Submitter Simon Marchi (Code Review)
Date Nov. 14, 2019, 11:35 p.m.
Message ID <gerrit.1573774548000.I63d658561028ac1bc0a0a2b7ac17da1b9c6134fe@gnutoolchain-gerrit.osci.io>
Download mbox | patch
Permalink /patch/35927/
State New
Headers show

Comments

Simon Marchi (Code Review) - Nov. 14, 2019, 11:35 p.m.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/645
......................................................................

Remove a call to update_exec_info

tui_show_frame_info calls update_exec_info after calling
erase_source_content, but there's no need to do this, as
erase_source_content already clears the exec info.

gdb/ChangeLog
2019-11-14  Tom Tromey  <tom@tromey.com>

	* tui/tui-stack.c (tui_show_frame_info): Don't call
	update_exec_info.

Change-Id: I63d658561028ac1bc0a0a2b7ac17da1b9c6134fe
---
M gdb/ChangeLog
M gdb/tui/tui-stack.c
2 files changed, 6 insertions(+), 4 deletions(-)

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7454ecd..1e04d77 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@ 
 2019-11-14  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui-stack.c (tui_show_frame_info): Don't call
+	update_exec_info.
+
+2019-11-14  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui.c (tui_enable): Call tui_display_main.
 
 2019-11-14  Tom Tromey  <tom@tromey.com>
diff --git a/gdb/tui/tui-stack.c b/gdb/tui/tui-stack.c
index 4f6fe8e..f42bd83 100644
--- a/gdb/tui/tui-stack.c
+++ b/gdb/tui/tui-stack.c
@@ -362,10 +362,7 @@ 
 	return 0;
 
       for (struct tui_source_window_base *win_info : tui_source_windows ())
-	{
-	  win_info->erase_source_content ();
-	  win_info->update_exec_info ();
-	}
+	win_info->erase_source_content ();
 
       return 1;
     }