Patchwork [review] Use bool in tui_before_prompt

login
register
mail settings
Submitter Simon Marchi (Code Review)
Date Nov. 14, 2019, 11:35 p.m.
Message ID <gerrit.1573774548000.I9c7f2b764748fe19621851dc4fed4775a6db211a@gnutoolchain-gerrit.osci.io>
Download mbox | patch
Permalink /patch/35925/
State New
Headers show

Comments

Simon Marchi (Code Review) - Nov. 14, 2019, 11:35 p.m.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/648
......................................................................

Use bool in tui_before_prompt

This changes tui_before_prompt to take a bool rather than an int.

gdb/ChangeLog
2019-11-14  Tom Tromey  <tom@tromey.com>

	* tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
	(tui_before_prompt, tui_normal_stop): Update.

Change-Id: I9c7f2b764748fe19621851dc4fed4775a6db211a
---
M gdb/ChangeLog
M gdb/tui/tui-hooks.c
2 files changed, 8 insertions(+), 3 deletions(-)

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index dbe3a93..f47d517 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@ 
 2019-11-14  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
+	(tui_before_prompt, tui_normal_stop): Update.
+
+2019-11-14  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui-winsource.c
 	(tui_source_window_base::update_source_window_as_is): Don't call
 	set_current_source_symtab_and_line.
diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c
index bb96f4d..35a9259 100644
--- a/gdb/tui/tui-hooks.c
+++ b/gdb/tui/tui-hooks.c
@@ -112,7 +112,7 @@ 
    if frame information hasn't changed.  */
 
 static void
-tui_refresh_frame_and_register_information (int registers_too_p)
+tui_refresh_frame_and_register_information (bool registers_too_p)
 {
   struct frame_info *fi;
   CORE_ADDR pc;
@@ -188,7 +188,7 @@ 
      refresh registers here unless the frame actually changed by one of these
      commands.  Registers will otherwise be refreshed after a normal stop or by
      our tui_register_changed_hook.  */
-  tui_refresh_frame_and_register_information (/*registers_too_p=*/0);
+  tui_refresh_frame_and_register_information (/*registers_too_p=*/false);
 }
 
 /* Observer for the normal_stop notification.  */
@@ -198,7 +198,7 @@ 
 {
   /* This refresh is intended to catch changes to the selected frame and to
      registers following a normal stop.  */
-  tui_refresh_frame_and_register_information (/*registers_too_p=*/1);
+  tui_refresh_frame_and_register_information (/*registers_too_p=*/true);
 }
 
 /* Token associated with observers registered while TUI hooks are