From patchwork Thu Nov 14 23:35:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35923 Received: (qmail 48310 invoked by alias); 14 Nov 2019 23:41:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 48279 invoked by uid 89); 14 Nov 2019 23:41:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2019 23:41:33 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id C038D20E94; Thu, 14 Nov 2019 18:36:04 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 49D4121171 for ; Thu, 14 Nov 2019 18:35:54 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id DD75528175 for ; Thu, 14 Nov 2019 18:35:52 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 14 Nov 2019 18:35:52 -0500 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Don't call tui_show_source from tui_ui_out X-Gerrit-Change-Id: Id71098e597ee4ebfef0429562baa45f537bd2c2b X-Gerrit-Change-Number: 652 X-Gerrit-ChangeURL: X-Gerrit-Commit: 586de76719ebab1e2c2aeda0a3bd760caf5856f6 References: Reply-To: tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/652 ...................................................................... Don't call tui_show_source from tui_ui_out This removes the call to tui_show_source from tui_ui_out. This always seemed like a hack, and now that the TUI is using the proper observers, it seems not to be needed. The rest of the logic remains, unfortunately, because it is needed to suppress some gdb output in the TUI case. We could probably find a nicer way to do this (maybe a ui_out_flag), but I haven't attempted this. gdb/ChangeLog 2019-11-14 Tom Tromey * tui/tui-out.c (tui_ui_out::do_field_string): Don't call tui_show_source. Change-Id: Id71098e597ee4ebfef0429562baa45f537bd2c2b --- M gdb/ChangeLog M gdb/tui/tui-out.c 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c8b9f19..a86057e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2019-11-14 Tom Tromey + * tui/tui-out.c (tui_ui_out::do_field_string): Don't call + tui_show_source. + +2019-11-14 Tom Tromey + * tui/tui-stack.h (tui_show_frame_info): Return bool. * tui/tui-stack.c (tui_show_frame_info): Return bool. * tui/tui-hooks.c (tui_refresh_frame_and_register_information): diff --git a/gdb/tui/tui-out.c b/gdb/tui/tui-out.c index 95543ff..22b4996 100644 --- a/gdb/tui/tui-out.c +++ b/gdb/tui/tui-out.c @@ -60,10 +60,7 @@ m_start_of_line++; if (fldname && m_line > 0 && strcmp (fldname, "fullname") == 0) - { - tui_show_source (); - return; - } + return; cli_ui_out::do_field_string (fldno, width, align, fldname, string, style); }