From patchwork Thu Nov 14 23:35:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35912 Received: (qmail 26824 invoked by alias); 14 Nov 2019 23:36:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 26717 invoked by uid 89); 14 Nov 2019 23:36:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2019 23:36:01 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 8111F20E5D; Thu, 14 Nov 2019 18:36:00 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 7231A210A7 for ; Thu, 14 Nov 2019 18:35:51 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 6864220AF6 for ; Thu, 14 Nov 2019 18:35:51 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 14 Nov 2019 18:35:51 -0500 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Simplify tui_update_source_windows_with_line X-Gerrit-Change-Id: I8803a0a6fd2938ceee859aea53a57ce582f3e80d X-Gerrit-Change-Number: 642 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6449d8af88e70352e57b26b339b7606f43214778 References: Reply-To: tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/642 ...................................................................... Simplify tui_update_source_windows_with_line This changes tui_update_source_windows_with_line to take a symtab_and_line, rather than separate parameters, and then updates the caller. gdb/ChangeLog 2019-11-14 Tom Tromey * tui/tui.c (tui_show_source): Update. * tui/tui-winsource.h (tui_update_source_windows_with_line): Update. * tui/tui-winsource.c (tui_update_source_windows_with_line): Take a symtab_symbol_info, not a separate symtab and line. Simplify. Change-Id: I8803a0a6fd2938ceee859aea53a57ce582f3e80d --- M gdb/ChangeLog M gdb/tui/tui-winsource.c M gdb/tui/tui-winsource.h M gdb/tui/tui.c 4 files changed, 17 insertions(+), 30 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 358a90f..fcd7b18 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2019-11-14 Tom Tromey + * tui/tui.c (tui_show_source): Update. + * tui/tui-winsource.h (tui_update_source_windows_with_line): Update. + * tui/tui-winsource.c (tui_update_source_windows_with_line): Take + a symtab_symbol_info, not a separate symtab and line. Simplify. + +2019-11-14 Tom Tromey + * tui/tui-winsource.c (tui_update_source_windows_with_addr): Simplify. diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c index e1b19cd..4b58311 100644 --- a/gdb/tui/tui-winsource.c +++ b/gdb/tui/tui-winsource.c @@ -207,38 +207,19 @@ win_info->update_source_window (gdbarch, sal); } -/* Function to ensure that the source and/or disassemly windows - reflect the input address. */ +/* Function to ensure that the source and/or disassembly windows + reflect the symtab and line. */ void -tui_update_source_windows_with_line (struct symtab *s, int line) +tui_update_source_windows_with_line (struct symtab_and_line sal) { - struct gdbarch *gdbarch; - CORE_ADDR pc; - struct symtab_and_line sal; - - if (!s) + if (!sal.symtab) return; - sal.symtab = s; - sal.line = line; + find_line_pc (sal.symtab, sal.line, &sal.pc); + struct gdbarch *gdbarch = get_objfile_arch (SYMTAB_OBJFILE (sal.symtab)); - gdbarch = get_objfile_arch (SYMTAB_OBJFILE (s)); - - switch (tui_current_layout ()) - { - case DISASSEM_COMMAND: - case DISASSEM_DATA_COMMAND: - find_line_pc (s, line, &pc); - tui_update_source_windows_with_addr (gdbarch, pc); - break; - default: - find_line_pc (s, line, &pc); - sal.pc = pc; - TUI_SRC_WIN->update_source_window (gdbarch, sal); - if (tui_current_layout () == SRC_DISASSEM_COMMAND) - TUI_DISASM_WIN->update_source_window (gdbarch, sal); - break; - } + for (struct tui_source_window_base *win_info : tui_source_windows ()) + win_info->update_source_window (gdbarch, sal); } void diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h index c66ea42..63042d1 100644 --- a/gdb/tui/tui-winsource.h +++ b/gdb/tui/tui-winsource.h @@ -227,8 +227,7 @@ /* Function to display the "main" routine. */ extern void tui_display_main (void); extern void tui_update_source_windows_with_addr (struct gdbarch *, CORE_ADDR); -extern void tui_update_source_windows_with_line (struct symtab *, - int); +extern void tui_update_source_windows_with_line (struct symtab_and_line sal); /* Extract some source text from PTR. LINE_NO is the line number. If it is positive, it is printed at the start of the line. FIRST_COL diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c index 472d0da..ae81fc9 100644 --- a/gdb/tui/tui.c +++ b/gdb/tui/tui.c @@ -633,7 +633,7 @@ /* Make sure that the source window is displayed. */ tui_add_win_to_layout (SRC_WIN); - tui_update_source_windows_with_line (cursal.symtab, cursal.line); + tui_update_source_windows_with_line (cursal); tui_update_locator_fullname (cursal.symtab); }