From patchwork Thu Nov 14 23:35:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35909 Received: (qmail 26399 invoked by alias); 14 Nov 2019 23:36:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 26318 invoked by uid 89); 14 Nov 2019 23:36:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=Answer X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2019 23:35:59 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id BAECD21086; Thu, 14 Nov 2019 18:35:57 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id E722920D23 for ; Thu, 14 Nov 2019 18:35:50 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id DA1AC28171 for ; Thu, 14 Nov 2019 18:35:50 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 14 Nov 2019 18:35:50 -0500 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Remove tui_source_window::show_symtab_source X-Gerrit-Change-Id: I41781df2126e8bafad46d058532d52602a288e06 X-Gerrit-Change-Number: 637 X-Gerrit-ChangeURL: X-Gerrit-Commit: 287e90fa351ee7fb60c353736637948a1c6ef27e References: Reply-To: tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/637 ...................................................................... Remove tui_source_window::show_symtab_source tui_source_window::show_symtab_source is identical to update_source_window, so remove the former. gdb/ChangeLog 2019-11-14 Tom Tromey * tui/tui-winsource.c (tui_update_source_windows_with_addr) (tui_update_source_windows_with_line): Call update_source_window. * tui/tui-source.h (struct tui_source_window) : Don't declare. * tui/tui-source.c (tui_source_window::show_symtab_source): Remove. Change-Id: I41781df2126e8bafad46d058532d52602a288e06 --- M gdb/ChangeLog M gdb/tui/tui-source.c M gdb/tui/tui-source.h M gdb/tui/tui-winsource.c 4 files changed, 11 insertions(+), 17 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index db53067..619815b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,14 @@ 2019-11-14 Tom Tromey + * tui/tui-winsource.c (tui_update_source_windows_with_addr) + (tui_update_source_windows_with_line): Call update_source_window. + * tui/tui-source.h (struct tui_source_window) + : Don't declare. + * tui/tui-source.c (tui_source_window::show_symtab_source): + Remove. + +2019-11-14 Tom Tromey + * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call update_source_window directly. * tui/tui-disasm.h (tui_show_disassem): Don't declare. diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c index cf0b8ce..197a3bb 100644 --- a/gdb/tui/tui-source.c +++ b/gdb/tui/tui-source.c @@ -112,18 +112,6 @@ } -/* Function to display source in the source window. This function - initializes the horizontal scroll to 0. */ -void -tui_source_window::show_symtab_source (struct gdbarch *gdbarch, - struct symtab *s, - struct tui_line_or_address line) -{ - horizontal_offset = 0; - update_source_window_as_is (gdbarch, s, line); -} - - /* Answer whether the source is currently displayed in the source window. */ bool diff --git a/gdb/tui/tui-source.h b/gdb/tui/tui-source.h index 15d1429..a573ce4 100644 --- a/gdb/tui/tui-source.h +++ b/gdb/tui/tui-source.h @@ -56,9 +56,6 @@ do_erase_source_content (_("[ No Source Available ]")); } - void show_symtab_source (struct gdbarch *, struct symtab *, - struct tui_line_or_address); - protected: void do_scroll_vertical (int num_to_scroll) override; diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c index 8b96fdf..ce4e655 100644 --- a/gdb/tui/tui-winsource.c +++ b/gdb/tui/tui-winsource.c @@ -220,7 +220,7 @@ { l.loa = LOA_LINE; l.u.line_no = sal.line; - TUI_SRC_WIN->show_symtab_source (gdbarch, sal.symtab, l); + TUI_SRC_WIN->update_source_window (gdbarch, sal.symtab, l); } } else @@ -254,7 +254,7 @@ default: l.loa = LOA_LINE; l.u.line_no = line; - TUI_SRC_WIN->show_symtab_source (gdbarch, s, l); + TUI_SRC_WIN->update_source_window (gdbarch, s, l); if (tui_current_layout () == SRC_DISASSEM_COMMAND) { find_line_pc (s, line, &pc);