From patchwork Thu Nov 14 23:35:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35905 Received: (qmail 25700 invoked by alias); 14 Nov 2019 23:35:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 25689 invoked by uid 89); 14 Nov 2019 23:35:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2019 23:35:56 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 63796211BD; Thu, 14 Nov 2019 18:35:52 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 87F0E203AF for ; Thu, 14 Nov 2019 18:35:50 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 6B4F428171 for ; Thu, 14 Nov 2019 18:35:50 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 14 Nov 2019 18:35:50 -0500 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Remove parameters from tui_show_source X-Gerrit-Change-Id: I7cbcf20175b459c269549f1832d4fb844cc573db X-Gerrit-Change-Number: 631 X-Gerrit-ChangeURL: X-Gerrit-Commit: a580d38b8169dd86ec92bf3716c6b5ed526f6451 References: Reply-To: tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/631 ...................................................................... Remove parameters from tui_show_source tui_show_source does not need its parameters, so this removes them. gdb/ChangeLog 2019-11-14 Tom Tromey * tui/tui.h (tui_show_source): Remove parameters. * tui/tui.c (tui_show_source): Remove parameters. * tui/tui-out.c (tui_ui_out::do_field_string): Update. Change-Id: I7cbcf20175b459c269549f1832d4fb844cc573db --- M gdb/ChangeLog M gdb/tui/tui-out.c M gdb/tui/tui.c M gdb/tui/tui.h 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 9876734..b2a7b24 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2019-11-14 Tom Tromey + * tui/tui.h (tui_show_source): Remove parameters. + * tui/tui.c (tui_show_source): Remove parameters. + * tui/tui-out.c (tui_ui_out::do_field_string): Update. + +2019-11-14 Tom Tromey + * tui/tui.c (tui_show_source): Update. * tui/tui-winsource.c (tui_display_main): Update. * tui/tui-stack.h (tui_update_locator_fullname): Change parameter diff --git a/gdb/tui/tui-out.c b/gdb/tui/tui-out.c index 0d3f3be..95543ff 100644 --- a/gdb/tui/tui-out.c +++ b/gdb/tui/tui-out.c @@ -61,7 +61,7 @@ if (fldname && m_line > 0 && strcmp (fldname, "fullname") == 0) { - tui_show_source (string, m_line); + tui_show_source (); return; } diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c index 0ec10b6..472d0da 100644 --- a/gdb/tui/tui.c +++ b/gdb/tui/tui.c @@ -626,14 +626,14 @@ #endif void -tui_show_source (const char *fullname, int line) +tui_show_source () { struct symtab_and_line cursal = get_current_source_symtab_and_line (); /* Make sure that the source window is displayed. */ tui_add_win_to_layout (SRC_WIN); - tui_update_source_windows_with_line (cursal.symtab, line); + tui_update_source_windows_with_line (cursal.symtab, cursal.line); tui_update_locator_fullname (cursal.symtab); } diff --git a/gdb/tui/tui.h b/gdb/tui/tui.h index dac410f..0ac1fb4 100644 --- a/gdb/tui/tui.h +++ b/gdb/tui/tui.h @@ -83,6 +83,6 @@ extern int tui_active; -extern void tui_show_source (const char *fullname, int line); +extern void tui_show_source (); #endif /* TUI_TUI_H */