Patchwork [review] Remove parameters from tui_show_source

login
register
mail settings
Submitter Simon Marchi (Code Review)
Date Nov. 14, 2019, 11:35 p.m.
Message ID <gerrit.1573774548000.I7cbcf20175b459c269549f1832d4fb844cc573db@gnutoolchain-gerrit.osci.io>
Download mbox | patch
Permalink /patch/35905/
State New
Headers show

Comments

Simon Marchi (Code Review) - Nov. 14, 2019, 11:35 p.m.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/631
......................................................................

Remove parameters from tui_show_source

tui_show_source does not need its parameters, so this removes them.

gdb/ChangeLog
2019-11-14  Tom Tromey  <tom@tromey.com>

	* tui/tui.h (tui_show_source): Remove parameters.
	* tui/tui.c (tui_show_source): Remove parameters.
	* tui/tui-out.c (tui_ui_out::do_field_string): Update.

Change-Id: I7cbcf20175b459c269549f1832d4fb844cc573db
---
M gdb/ChangeLog
M gdb/tui/tui-out.c
M gdb/tui/tui.c
M gdb/tui/tui.h
4 files changed, 10 insertions(+), 4 deletions(-)

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9876734..b2a7b24 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@ 
 2019-11-14  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui.h (tui_show_source): Remove parameters.
+	* tui/tui.c (tui_show_source): Remove parameters.
+	* tui/tui-out.c (tui_ui_out::do_field_string): Update.
+
+2019-11-14  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui.c (tui_show_source): Update.
 	* tui/tui-winsource.c (tui_display_main): Update.
 	* tui/tui-stack.h (tui_update_locator_fullname): Change parameter
diff --git a/gdb/tui/tui-out.c b/gdb/tui/tui-out.c
index 0d3f3be..95543ff 100644
--- a/gdb/tui/tui-out.c
+++ b/gdb/tui/tui-out.c
@@ -61,7 +61,7 @@ 
 
   if (fldname && m_line > 0 && strcmp (fldname, "fullname") == 0)
     {
-      tui_show_source (string, m_line);
+      tui_show_source ();
       return;
     }
 
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index 0ec10b6..472d0da 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -626,14 +626,14 @@ 
 #endif
 
 void
-tui_show_source (const char *fullname, int line)
+tui_show_source ()
 {
   struct symtab_and_line cursal = get_current_source_symtab_and_line ();
 
   /* Make sure that the source window is displayed.  */
   tui_add_win_to_layout (SRC_WIN);
 
-  tui_update_source_windows_with_line (cursal.symtab, line);
+  tui_update_source_windows_with_line (cursal.symtab, cursal.line);
   tui_update_locator_fullname (cursal.symtab);
 }
 
diff --git a/gdb/tui/tui.h b/gdb/tui/tui.h
index dac410f..0ac1fb4 100644
--- a/gdb/tui/tui.h
+++ b/gdb/tui/tui.h
@@ -83,6 +83,6 @@ 
 
 extern int tui_active;
 
-extern void tui_show_source (const char *fullname, int line);
+extern void tui_show_source ();
 
 #endif /* TUI_TUI_H */