From patchwork Wed Nov 13 02:34:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35853 Received: (qmail 128440 invoked by alias); 13 Nov 2019 02:34:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 128431 invoked by uid 89); 13 Nov 2019 02:34:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1698 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Nov 2019 02:34:08 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 5FE2620339; Tue, 12 Nov 2019 21:34:06 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 5A17C20339; Tue, 12 Nov 2019 21:34:05 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 3D55820AF6; Tue, 12 Nov 2019 21:34:05 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Tue, 12 Nov 2019 21:34:05 -0500 From: "Christian Biesinger (Code Review)" To: gdb-patches@sourceware.org Cc: Christian Biesinger Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Add a dependency on import/Makefile and config.h X-Gerrit-Change-Id: I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408 X-Gerrit-Change-Number: 622 X-Gerrit-ChangeURL: X-Gerrit-Commit: 591211cacdb5d3c5aa70380476b3a166296f6e64 References: Reply-To: cbiesinger@google.com, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/622 ...................................................................... Add a dependency on import/Makefile and config.h Otherwise, since nothing else depends on that, the Makefile won't be regenerated when necessary, which is problematic when importing new gnulib modules. gnulib/ChangeLog: 2019-11-12 Christian Biesinger * Makefile.in: Depend on import/Makefile and config.h. Change-Id: I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408 --- M gnulib/Makefile.in 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnulib/Makefile.in b/gnulib/Makefile.in index a9879ed..2a00020 100644 --- a/gnulib/Makefile.in +++ b/gnulib/Makefile.in @@ -112,7 +112,7 @@ "RUNTEST=$(RUNTEST)" \ "RUNTESTFLAGS=$(RUNTESTFLAGS)" -all installcheck check info install-info clean-info dvi pdf install-pdf html install-html: force +all installcheck check info install-info clean-info dvi pdf install-pdf html install-html: force import/Makefile config.h @$(MAKE) $(FLAGS_TO_PASS) DO=$@ "DODIRS=$(SUBDIRS)" subdir_do # Traditionally "install" depends on "all". But it may be useful @@ -131,7 +131,7 @@ # Convenience rule to handle recursion. $(LIBGNU) $(GNULIB_H): all-lib -all-lib: import/Makefile +all-lib: import/Makefile config.h @$(MAKE) $(FLAGS_TO_PASS) DO=all DODIRS=import subdir_do .PHONY: all-lib