Patchwork [review] gnulib: Fix path to import/Makefile{,.in}

login
register
mail settings
Submitter Simon Marchi (Code Review)
Date Nov. 13, 2019, 2:19 a.m.
Message ID <gerrit.1573611546000.Ib7f6a319ee764d20072e38911766ca7032d6ca8e@gnutoolchain-gerrit.osci.io>
Download mbox | patch
Permalink /patch/35852/
State New
Headers show

Comments

Simon Marchi (Code Review) - Nov. 13, 2019, 2:19 a.m.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/621
......................................................................

gnulib: Fix path to import/Makefile{,.in}

This is probably (?) a leftover from when gnulib was inside the gdb/
directory.

gnulib/ChangeLog:

2019-11-12  Christian Biesinger  <cbiesinger@google.com>

	* Makefile.in: Fix path to say import/ instead of gnulib/.

Change-Id: Ib7f6a319ee764d20072e38911766ca7032d6ca8e
---
M gnulib/Makefile.in
1 file changed, 2 insertions(+), 2 deletions(-)
Simon Marchi (Code Review) - Nov. 13, 2019, 3:19 a.m.
Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/621
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,18 @@ 
| +Parent:     7722d40a (RISC-V: Support the INSN_CLASS.*F.* classes for .insn directive.)
| +Author:     Christian Biesinger <cbiesinger@google.com>
| +AuthorDate: 2019-11-12 20:11:37 -0600
| +Commit:     Christian Biesinger <cbiesinger@google.com>
| +CommitDate: 2019-11-12 20:18:36 -0600
| +
| +gnulib: Fix path to import/Makefile{,.in}
| +
| +This is probably (?) a leftover from when gnulib was inside the gdb/
| +directory.

PS1, Line 10:

Actually, this is probably from a long time ago.  Even before moving
gnulib to the top-level, it should have been import/Makefile.

| +
| +gnulib/ChangeLog:
| +
| +2019-11-12  Christian Biesinger  <cbiesinger@google.com>
| +
| +	* Makefile.in: Fix path to say import/ instead of gnulib/.
| +
| +Change-Id: Ib7f6a319ee764d20072e38911766ca7032d6ca8e
Simon Marchi (Code Review) - Nov. 13, 2019, 7:55 p.m.
Pedro Alves has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/621
......................................................................


Patch Set 2:

(1 comment)

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,18 @@ 
| +Parent:     7722d40a (RISC-V: Support the INSN_CLASS.*F.* classes for .insn directive.)
| +Author:     Christian Biesinger <cbiesinger@google.com>
| +AuthorDate: 2019-11-12 20:11:37 -0600
| +Commit:     Christian Biesinger <cbiesinger@google.com>
| +CommitDate: 2019-11-12 20:18:36 -0600
| +
| +gnulib: Fix path to import/Makefile{,.in}
| +
| +This is probably (?) a leftover from when gnulib was inside the gdb/
| +directory.

PS1, Line 10:

> Actually, this is probably from a long time ago.  Even before moving gnulib to the top-level, it should have been import/Makefile.

The import directory originally didn't exist.  Sounds like it was
missed in the move from gdb/gnulib/ -> gnu/gnulib/import/

For reference:
 https://sourceware.org/ml/gdb-patches/2012-04/msg00559.html
 https://sourceware.org/ml/gdb-patches/2012-04/msg00631.html
 https://sourceware.org/ml/gdb-patches/2012-04/msg00646.html

| +
| +gnulib/ChangeLog:
| +
| +2019-11-12  Christian Biesinger  <cbiesinger@google.com>
| +
| +	* Makefile.in: Fix path to say import/ instead of gnulib/.
| +
| +Change-Id: Ib7f6a319ee764d20072e38911766ca7032d6ca8e

Patch

diff --git a/gnulib/Makefile.in b/gnulib/Makefile.in
index c42bb23..a9879ed 100644
--- a/gnulib/Makefile.in
+++ b/gnulib/Makefile.in
@@ -180,8 +180,8 @@ 
 	  CONFIG_HEADERS= \
 	  $(SHELL) config.status
 
-gnulib/Makefile: gnulib/Makefile.in config.status
-	CONFIG_FILES="gnulib/Makefile" \
+import/Makefile: import/Makefile.in config.status
+	CONFIG_FILES="import/Makefile" \
 	  CONFIG_COMMANDS="depfiles" \
 	  CONFIG_HEADERS= \
 	  CONFIG_LINKS= \