[review] support: Fix support_set_small_thread_stack_size to build on Hurd
Commit Message
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/620
......................................................................
support: Fix support_set_small_thread_stack_size to build on Hurd
PTHREAD_STACK_MIN comes from <limits.h>, so include it explicitly.
However, it is not defined on Hurd, so compensate for that as well.
Built on x86_64-linux-gnu, i686-linux-gnu, i686-gnu.
Change-Id: Ifacc888ef86731c2639721b0932ae59583bd6b3e
---
M support/support_set_small_thread_stack_size.c
1 file changed, 7 insertions(+), 2 deletions(-)
Comments
Christian Brauner has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/620
......................................................................
Patch Set 1: Code-Review+2
Looks reasonable.
Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/620
......................................................................
Patch Set 2: Code-Review+2
@@ -16,9 +16,9 @@
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
+#include <limits.h>
#include <pthread.h>
#include <support/xthread.h>
-#include <sys/param.h>
void
support_set_small_thread_stack_size (pthread_attr_t *attr)
@@ -26,5 +26,10 @@
/* Some architectures have too small values for PTHREAD_STACK_MIN
which cannot be used for creating threads. Ensure that the stack
size is at least 256 KiB. */
- xpthread_attr_setstacksize (attr, MAX (256 * 1024, PTHREAD_STACK_MIN));
+ size_t stack_size = 256 * 1024;
+#ifdef PTHREAD_STACK_MIN
+ if (stack_size < PTHREAD_STACK_MIN)
+ stack_size = PTHREAD_STACK_MIN;
+#endif
+ xpthread_attr_setstacksize (attr, stack_size);
}