From patchwork Mon Nov 4 15:27:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Liebler X-Patchwork-Id: 35627 Received: (qmail 111696 invoked by alias); 4 Nov 2019 16:04:21 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 111684 invoked by uid 89); 4 Nov 2019 16:04:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com From: Stefan Liebler To: libc-alpha@sourceware.org Cc: Stefan Liebler Subject: [PATCH 14/17] S390: Use libc_fe* macros in fe* functions. Date: Mon, 4 Nov 2019 16:27:21 +0100 In-Reply-To: <1572881244-6781-1-git-send-email-stli@linux.ibm.com> References: <1572881244-6781-1-git-send-email-stli@linux.ibm.com> x-cbid: 19110415-0012-0000-0000-00000360944B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19110415-0013-0000-0000-0000219BE9D0 Message-Id: <1572881244-6781-14-git-send-email-stli@linux.ibm.com> This patch updates the s390 specific functions fegetround, fesetround, feholdexcept, fesetenv, feupdateenv, fegetexceptflag, fetestexcept, fesetexceptflag, fetestexceptflag. Now those functions are using the libc_fe* macros if possible. Furthermore fegetexceptflag is now returning the exception from dxc field shifted to the usual exception-flags. Thus a special fetestexceptflag implementation is not needed anymore. --- sysdeps/s390/fpu/fegetround.c | 9 ++------- sysdeps/s390/fpu/feholdexcpt.c | 12 ++--------- sysdeps/s390/fpu/fesetenv.c | 21 +++---------------- sysdeps/s390/fpu/fesetround.c | 9 +++------ sysdeps/s390/fpu/fetestexceptflag.c | 31 ----------------------------- sysdeps/s390/fpu/feupdateenv.c | 14 +++---------- sysdeps/s390/fpu/fgetexcptflg.c | 16 ++------------- sysdeps/s390/fpu/fsetexcptflg.c | 23 ++++++++++----------- sysdeps/s390/fpu/ftestexcept.c | 16 ++------------- 9 files changed, 27 insertions(+), 124 deletions(-) delete mode 100644 sysdeps/s390/fpu/fetestexceptflag.c diff --git a/sysdeps/s390/fpu/fegetround.c b/sysdeps/s390/fpu/fegetround.c index 8e61605bad..847b5d2de5 100644 --- a/sysdeps/s390/fpu/fegetround.c +++ b/sysdeps/s390/fpu/fegetround.c @@ -17,17 +17,12 @@ License along with the GNU C Library; if not, see . */ -#include -#include +#include int __fegetround (void) { - fexcept_t cw; - - _FPU_GETCW (cw); - - return cw & FPC_RM_MASK; + return get_rounding_mode (); } libm_hidden_def (__fegetround) weak_alias (__fegetround, fegetround) diff --git a/sysdeps/s390/fpu/feholdexcpt.c b/sysdeps/s390/fpu/feholdexcpt.c index 8ad7d530bd..e2eb5d2a77 100644 --- a/sysdeps/s390/fpu/feholdexcpt.c +++ b/sysdeps/s390/fpu/feholdexcpt.c @@ -17,19 +17,11 @@ License along with the GNU C Library; if not, see . */ -#include -#include +#include int __feholdexcept (fenv_t *envp) { - fexcept_t fpc; - /* Store the environment. */ - __fegetenv (envp); - /* Clear the current sticky bits as more than one exception - may be generated. */ - fpc = envp->__fpc & ~(FPC_FLAGS_MASK | FPC_DXC_MASK); - /* Hold from generating fpu exceptions temporarily. */ - _FPU_SETCW ((fpc & ~(FE_ALL_EXCEPT << FPC_EXCEPTION_MASK_SHIFT))); + libc_feholdexcept_s390 (envp); return 0; } libm_hidden_def (__feholdexcept) diff --git a/sysdeps/s390/fpu/fesetenv.c b/sysdeps/s390/fpu/fesetenv.c index ede3d89b3b..dca26033a7 100644 --- a/sysdeps/s390/fpu/fesetenv.c +++ b/sysdeps/s390/fpu/fesetenv.c @@ -17,28 +17,13 @@ License along with the GNU C Library; if not, see . */ -#include -#include -#include -#include +#include int __fesetenv (const fenv_t *envp) { - fenv_t env; - - if (envp == FE_DFL_ENV) - { - env.__fpc = _FPU_DEFAULT; - } - else if (envp == FE_NOMASK_ENV) - { - env.__fpc = FPC_EXCEPTION_MASK; - } - else - env = (*envp); - - _FPU_SETCW (env.__fpc); + fenv_t env = libc_handle_user_fenv_s390 (envp); + libc_fesetenv_s390 (&env); /* Success. */ return 0; diff --git a/sysdeps/s390/fpu/fesetround.c b/sysdeps/s390/fpu/fesetround.c index 38ec4284d3..752b41a171 100644 --- a/sysdeps/s390/fpu/fesetround.c +++ b/sysdeps/s390/fpu/fesetround.c @@ -17,21 +17,18 @@ License along with the GNU C Library; if not, see . */ -#include -#include +#include int __fesetround (int round) { - if ((round|FPC_RM_MASK) != FPC_RM_MASK) + if ((round | FPC_RM_MASK) != FPC_RM_MASK) { /* ROUND is not a valid rounding mode. */ return 1; } - __asm__ __volatile__ ("srnm 0(%0)" - : - : "a" (round)); + libc_fesetround_s390 (round); return 0; } libm_hidden_def (__fesetround) diff --git a/sysdeps/s390/fpu/fetestexceptflag.c b/sysdeps/s390/fpu/fetestexceptflag.c deleted file mode 100644 index e8badeb13e..0000000000 --- a/sysdeps/s390/fpu/fetestexceptflag.c +++ /dev/null @@ -1,31 +0,0 @@ -/* Test exception in saved exception state. S/390 version. - Copyright (C) 2016-2019 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; if not, see - . */ - -#include -#include - -int -fetestexceptflag (const fexcept_t *flagp, int excepts) -{ - /* As *flagp is obtained by an earlier call of fegetexceptflag the - bits 0-5 of dxc-byte are either zero or correspond to the - flag-bits. Evaluate flags and last dxc-exception-code. */ - return (((*flagp >> FPC_FLAGS_SHIFT) | (*flagp >> FPC_DXC_SHIFT)) - & excepts - & FE_ALL_EXCEPT); -} diff --git a/sysdeps/s390/fpu/feupdateenv.c b/sysdeps/s390/fpu/feupdateenv.c index e6b1ff8ff1..9ddff724e6 100644 --- a/sysdeps/s390/fpu/feupdateenv.c +++ b/sysdeps/s390/fpu/feupdateenv.c @@ -18,21 +18,13 @@ . */ -#include -#include +#include int __feupdateenv (const fenv_t *envp) { - fexcept_t temp; - - _FPU_GETCW (temp); - temp = (temp & FPC_FLAGS_MASK) >> FPC_FLAGS_SHIFT; - - /* Raise the exceptions since the last call to feholdenv */ - /* re install saved environment. */ - __fesetenv (envp); - __feraiseexcept ((int) temp); + fenv_t env = libc_handle_user_fenv_s390 (envp); + libc_feupdateenv_s390 (&env); /* Success. */ return 0; diff --git a/sysdeps/s390/fpu/fgetexcptflg.c b/sysdeps/s390/fpu/fgetexcptflg.c index 779eec83bc..7231752029 100644 --- a/sysdeps/s390/fpu/fgetexcptflg.c +++ b/sysdeps/s390/fpu/fgetexcptflg.c @@ -17,24 +17,12 @@ License along with the GNU C Library; if not, see . */ -#include -#include +#include int fegetexceptflag (fexcept_t *flagp, int excepts) { - fexcept_t temp, newexcepts; - - /* Get the current exceptions. */ - _FPU_GETCW (temp); - newexcepts = excepts << FPC_FLAGS_SHIFT; - if ((temp & FPC_NOT_FPU_EXCEPTION) == 0) - /* Bits 6, 7 of dxc-byte are zero, - thus bits 0-5 of dxc-byte correspond to the flag-bits. - Evaluate flags and last dxc-exception-code. */ - newexcepts |= excepts << FPC_DXC_SHIFT; - - *flagp = temp & newexcepts; + *flagp = libc_fetestexcept_s390 (excepts); /* Success. */ return 0; diff --git a/sysdeps/s390/fpu/fsetexcptflg.c b/sysdeps/s390/fpu/fsetexcptflg.c index b3e4bbf878..0b9517ef59 100644 --- a/sysdeps/s390/fpu/fsetexcptflg.c +++ b/sysdeps/s390/fpu/fsetexcptflg.c @@ -24,29 +24,26 @@ int fesetexceptflag (const fexcept_t *flagp, int excepts) { - fexcept_t temp, newexcepts; + fexcept_t fpc, fpc_new; /* Get the current environment. We have to do this since we cannot separately set the status word. */ - _FPU_GETCW (temp); - /* Install the new exception bits in the Accrued Exception Byte. */ - excepts = excepts & FE_ALL_EXCEPT; - newexcepts = excepts << FPC_FLAGS_SHIFT; - temp &= ~newexcepts; - if ((temp & FPC_NOT_FPU_EXCEPTION) == 0) + _FPU_GETCW (fpc); + + /* Clear the current exception bits. */ + fpc_new = fpc & ~((excepts & FE_ALL_EXCEPT) << FPC_FLAGS_SHIFT); + if ((fpc & FPC_NOT_FPU_EXCEPTION) == 0) /* Bits 6, 7 of dxc-byte are zero, thus bits 0-5 of dxc-byte correspond to the flag-bits. Clear given exceptions in dxc-field. */ - temp &= ~(excepts << FPC_DXC_SHIFT); + fpc_new &= ~((excepts & FE_ALL_EXCEPT) << FPC_DXC_SHIFT); - /* Integrate dxc-byte of flagp into flags. The dxc-byte of flagp contains - either an ieee-exception or 0 (see fegetexceptflag). */ - temp |= (*flagp | ((*flagp >> FPC_DXC_SHIFT) << FPC_FLAGS_SHIFT)) - & newexcepts; + /* Set exceptions from flagp in flags-field. */ + fpc_new |= (*flagp & excepts & FE_ALL_EXCEPT) << FPC_FLAGS_SHIFT; /* Store the new status word (along with the rest of the environment. Possibly new exceptions are set but they won't get executed. */ - _FPU_SETCW (temp); + _FPU_SETCW (fpc_new); /* Success. */ return 0; diff --git a/sysdeps/s390/fpu/ftestexcept.c b/sysdeps/s390/fpu/ftestexcept.c index eabc1b65b9..ed7df8b02b 100644 --- a/sysdeps/s390/fpu/ftestexcept.c +++ b/sysdeps/s390/fpu/ftestexcept.c @@ -17,23 +17,11 @@ License along with the GNU C Library; if not, see . */ -#include -#include +#include int fetestexcept (int excepts) { - fexcept_t temp, res; - - /* Get current exceptions. */ - _FPU_GETCW (temp); - res = temp >> FPC_FLAGS_SHIFT; - if ((temp & FPC_NOT_FPU_EXCEPTION) == 0) - /* Bits 6, 7 of dxc-byte are zero, - thus bits 0-5 of dxc-byte correspond to the flag-bits. - Evaluate flags and last dxc-exception-code. */ - res |= temp >> FPC_DXC_SHIFT; - - return res & excepts & FE_ALL_EXCEPT; + return libc_fetestexcept_s390 (excepts); } libm_hidden_def (fetestexcept)