diff mbox

[review] Rename windows_thread_info::id to "tid"

Message ID gerrit.1572371871000.Ia4b72201c53716b15a7a6753982988c35ced137f@gnutoolchain-gerrit.osci.io
State New, archived
Headers

Commit Message

Simon Marchi (Code Review) Oct. 29, 2019, 5:57 p.m. UTC 
  Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/406
......................................................................

Rename windows_thread_info::id to "tid"

This changes the name of a field in windows_thread_info, bringing gdb
and gdbserver closer into sync.

gdb/ChangeLog
2019-10-29  Tom Tromey  <tromey@adacore.com>

	* windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
	(thread_rec, windows_add_thread, windows_delete_thread)
	(windows_continue): Update.

Change-Id: Ia4b72201c53716b15a7a6753982988c35ced137f
---
M gdb/ChangeLog
M gdb/windows-nat.c
2 files changed, 11 insertions(+), 5 deletions(-)

Comments

Simon Marchi (Code Review) Oct. 31, 2019, 3:42 a.m. UTC | #1 
Luis Machado has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/406
......................................................................


Patch Set 1: Code-Review+1

Looks sane.
Simon Marchi (Code Review) Oct. 31, 2019, 2:22 p.m. UTC | #2 
Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/406
......................................................................


Patch Set 1: Code-Review+2
Simon Marchi (Code Review) Nov. 29, 2019, 5:50 p.m. UTC | #3 
Pedro Alves has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/406
......................................................................


Patch Set 2: Code-Review+2
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d255440..be5ea7b 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@ 
 2019-10-29  Tom Tromey  <tromey@adacore.com>
 
+	* windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
+	(thread_rec, windows_add_thread, windows_delete_thread)
+	(windows_continue): Update.
+
+2019-10-29  Tom Tromey  <tromey@adacore.com>
+
 	* windows-nat.c (struct windows_thread_info): Remove typedef.
 	(thread_head): Remove.
 	(thread_list): New global.
diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index 3bd8c0f..60b9cb5 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -217,7 +217,7 @@ 
    not available in gdb's thread structure.  */
 struct windows_thread_info
   {
-    DWORD id;
+    DWORD tid;
     HANDLE h;
     CORE_ADDR thread_local_base;
     char *name;
@@ -384,7 +384,7 @@ 
 thread_rec (DWORD id, int get_context)
 {
   for (windows_thread_info *th : thread_list)
-    if (th->id == id)
+    if (th->tid == id)
       {
 	if (!th->suspended && get_context)
 	  {
@@ -442,7 +442,7 @@ 
     return th;
 
   th = XCNEW (windows_thread_info);
-  th->id = id;
+  th->tid = id;
   th->h = h;
   th->thread_local_base = (CORE_ADDR) (uintptr_t) tlb;
   thread_list.push_back (th);
@@ -524,7 +524,7 @@ 
   auto iter = std::find_if (thread_list.begin (), thread_list.end (),
 			    [=] (windows_thread_info *th)
 			    {
-			      return th->id == id;
+			      return th->tid == id;
 			    });
 
   if (iter != thread_list.end ())
@@ -1319,7 +1319,7 @@ 
 		  "DBG_CONTINUE" : "DBG_EXCEPTION_NOT_HANDLED"));
 
   for (windows_thread_info *th : thread_list)
-    if ((id == -1 || id == (int) th->id)
+    if ((id == -1 || id == (int) th->tid)
 	&& th->suspended)
       {
 	if (debug_registers_changed)