Patchwork [review] Check for sigprocmask in common.m4

login
register
mail settings
Submitter Simon Marchi (Code Review)
Date Oct. 20, 2019, 3:55 a.m.
Message ID <gerrit.1571543710000.I2c0a4dd2c376507b9483b38707a242382faa8163@gnutoolchain-gerrit.osci.io>
Download mbox | patch
Permalink /patch/35168/
State New
Headers show

Comments

Simon Marchi (Code Review) - Oct. 20, 2019, 3:55 a.m.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/165
......................................................................

Check for sigprocmask in common.m4

I noticed that gdbsupport uses HAVE_SIGPROCMASK, but common.m4 does
not check for it.  This means that gdbserver may not compile some
gdbsupport code properly.  This patch fixes this error.

gdb/ChangeLog
2019-10-19  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.
	* configure.ac: Don't check for sigprocmask.
	* gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.

gdb/gdbserver/ChangeLog
2019-10-19  Tom Tromey  <tom@tromey.com>

	* configure, config.in: Rebuild.

Change-Id: I2c0a4dd2c376507b9483b38707a242382faa8163
---
M gdb/ChangeLog
M gdb/configure
M gdb/configure.ac
M gdb/gdbserver/ChangeLog
M gdb/gdbserver/config.in
M gdb/gdbserver/configure
M gdb/gdbsupport/common.m4
7 files changed, 21 insertions(+), 5 deletions(-)
Simon Marchi (Code Review) - Oct. 21, 2019, 6:05 a.m.
Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/165
......................................................................


Patch Set 2: Code-Review+2

LGTM, I think you could push this one right away, it's a good cleanup regardless of the rest of the series.

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c4d402f..731f81c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,6 +1,12 @@ 
 2019-10-19  Tom Tromey  <tom@tromey.com>
 
 	* configure: Rebuild.
+	* configure.ac: Don't check for sigprocmask.
+	* gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
+
+2019-10-19  Tom Tromey  <tom@tromey.com>
+
+	* configure: Rebuild.
 	* acinclude.m4: Use m4_include, not sinclude.
 
 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
diff --git a/gdb/configure b/gdb/configure
index 70ce52f..36460b8 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -13120,7 +13120,7 @@ 
 for ac_func in getauxval getrusage getuid getgid \
 		pipe poll pread pread64 pwrite resize_term \
 		sbrk getpgid setpgid setpgrp setsid \
-		sigaction sigprocmask sigsetmask socketpair \
+		sigaction sigsetmask socketpair \
 		ttrace wborder wresize setlocale iconvlist libiconvlist btowc \
 		setrlimit getrlimit posix_madvise waitpid \
 		ptrace64 sigaltstack setns use_default_colors
@@ -13529,7 +13529,8 @@ 
 done
 
 
-  for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction
+  for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction \
+		  sigprocmask
 do :
   as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
 ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
diff --git a/gdb/configure.ac b/gdb/configure.ac
index c4e0dbf..238a934 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1363,7 +1363,7 @@ 
 AC_CHECK_FUNCS([getauxval getrusage getuid getgid \
 		pipe poll pread pread64 pwrite resize_term \
 		sbrk getpgid setpgid setpgrp setsid \
-		sigaction sigprocmask sigsetmask socketpair \
+		sigaction sigsetmask socketpair \
 		ttrace wborder wresize setlocale iconvlist libiconvlist btowc \
 		setrlimit getrlimit posix_madvise waitpid \
 		ptrace64 sigaltstack setns use_default_colors])
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 02033ae..e3a7ebe 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,5 +1,9 @@ 
 2019-10-19  Tom Tromey  <tom@tromey.com>
 
+	* configure, config.in: Rebuild.
+
+2019-10-19  Tom Tromey  <tom@tromey.com>
+
 	* configure: Rebuild.
 	* acinclude.m4: Use m4_include, not sinclude.
 
diff --git a/gdb/gdbserver/config.in b/gdb/gdbserver/config.in
index f05e9be..0bce18d 100644
--- a/gdb/gdbserver/config.in
+++ b/gdb/gdbserver/config.in
@@ -211,6 +211,9 @@ 
 /* Define to 1 if you have the <signal.h> header file. */
 #undef HAVE_SIGNAL_H
 
+/* Define to 1 if you have the `sigprocmask' function. */
+#undef HAVE_SIGPROCMASK
+
 /* Define if sigsetjmp is available. */
 #undef HAVE_SIGSETJMP
 
diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
index 5c84eeb..e513fc5 100755
--- a/gdb/gdbserver/configure
+++ b/gdb/gdbserver/configure
@@ -6821,7 +6821,8 @@ 
 done
 
 
-  for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction
+  for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction \
+		  sigprocmask
 do :
   as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
 ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
diff --git a/gdb/gdbsupport/common.m4 b/gdb/gdbsupport/common.m4
index 9038894..471d705 100644
--- a/gdb/gdbsupport/common.m4
+++ b/gdb/gdbsupport/common.m4
@@ -32,7 +32,8 @@ 
 		   termios.h dnl
 		   dlfcn.h)
 
-  AC_CHECK_FUNCS([fdwalk getrlimit pipe pipe2 socketpair sigaction])
+  AC_CHECK_FUNCS([fdwalk getrlimit pipe pipe2 socketpair sigaction \
+		  sigprocmask])
 
   AC_CHECK_DECLS([strerror, strstr])