[review] Check for sigprocmask in common.m4
Commit Message
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/165
......................................................................
Check for sigprocmask in common.m4
I noticed that gdbsupport uses HAVE_SIGPROCMASK, but common.m4 does
not check for it. This means that gdbserver may not compile some
gdbsupport code properly. This patch fixes this error.
gdb/ChangeLog
2019-10-19 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
* configure.ac: Don't check for sigprocmask.
* gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
gdb/gdbserver/ChangeLog
2019-10-19 Tom Tromey <tom@tromey.com>
* configure, config.in: Rebuild.
Change-Id: I2c0a4dd2c376507b9483b38707a242382faa8163
---
M gdb/ChangeLog
M gdb/configure
M gdb/configure.ac
M gdb/gdbserver/ChangeLog
M gdb/gdbserver/config.in
M gdb/gdbserver/configure
M gdb/gdbsupport/common.m4
7 files changed, 21 insertions(+), 5 deletions(-)
Comments
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/165
......................................................................
Patch Set 2: Code-Review+2
LGTM, I think you could push this one right away, it's a good cleanup regardless of the rest of the series.
@@ -1,6 +1,12 @@
2019-10-19 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
+ * configure.ac: Don't check for sigprocmask.
+ * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
+
+2019-10-19 Tom Tromey <tom@tromey.com>
+
+ * configure: Rebuild.
* acinclude.m4: Use m4_include, not sinclude.
2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
@@ -13120,7 +13120,7 @@
for ac_func in getauxval getrusage getuid getgid \
pipe poll pread pread64 pwrite resize_term \
sbrk getpgid setpgid setpgrp setsid \
- sigaction sigprocmask sigsetmask socketpair \
+ sigaction sigsetmask socketpair \
ttrace wborder wresize setlocale iconvlist libiconvlist btowc \
setrlimit getrlimit posix_madvise waitpid \
ptrace64 sigaltstack setns use_default_colors
@@ -13529,7 +13529,8 @@
done
- for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction
+ for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction \
+ sigprocmask
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
@@ -1363,7 +1363,7 @@
AC_CHECK_FUNCS([getauxval getrusage getuid getgid \
pipe poll pread pread64 pwrite resize_term \
sbrk getpgid setpgid setpgrp setsid \
- sigaction sigprocmask sigsetmask socketpair \
+ sigaction sigsetmask socketpair \
ttrace wborder wresize setlocale iconvlist libiconvlist btowc \
setrlimit getrlimit posix_madvise waitpid \
ptrace64 sigaltstack setns use_default_colors])
@@ -1,5 +1,9 @@
2019-10-19 Tom Tromey <tom@tromey.com>
+ * configure, config.in: Rebuild.
+
+2019-10-19 Tom Tromey <tom@tromey.com>
+
* configure: Rebuild.
* acinclude.m4: Use m4_include, not sinclude.
@@ -211,6 +211,9 @@
/* Define to 1 if you have the <signal.h> header file. */
#undef HAVE_SIGNAL_H
+/* Define to 1 if you have the `sigprocmask' function. */
+#undef HAVE_SIGPROCMASK
+
/* Define if sigsetjmp is available. */
#undef HAVE_SIGSETJMP
@@ -6821,7 +6821,8 @@
done
- for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction
+ for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction \
+ sigprocmask
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
@@ -32,7 +32,8 @@
termios.h dnl
dlfcn.h)
- AC_CHECK_FUNCS([fdwalk getrlimit pipe pipe2 socketpair sigaction])
+ AC_CHECK_FUNCS([fdwalk getrlimit pipe pipe2 socketpair sigaction \
+ sigprocmask])
AC_CHECK_DECLS([strerror, strstr])