Patchwork [pushed] gdb: Make startswith return a bool

login
register
mail settings
Submitter Simon Marchi (Code Review)
Date Oct. 19, 2019, 9:02 p.m.
Message ID <20191019210205.B1ABA20AF7@gnutoolchain-gerrit.osci.io>
Download mbox | patch
Permalink /patch/35163/
State New
Headers show

Comments

Simon Marchi (Code Review) - Oct. 19, 2019, 9:02 p.m.
Sourceware to Gerrit sync has submitted this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/162
......................................................................

gdb: Make startswith return a bool

gdb/ChangeLog:

	* gdbsupport/common-utils.h (startswith): Change return type to
	bool.

Change-Id: I1c11b9bb7f89b3885c1bb55097adb5be6d333ad4
---
M gdb/ChangeLog
M gdb/gdbsupport/common-utils.h
2 files changed, 7 insertions(+), 3 deletions(-)

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d8e3fe1..7c737ac 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
+
+	* gdbsupport/common-utils.h (startswith): Change return type to
+	bool.
+
 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 
 	* bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
diff --git a/gdb/gdbsupport/common-utils.h b/gdb/gdbsupport/common-utils.h
index a5312cb..e96fc21 100644
--- a/gdb/gdbsupport/common-utils.h
+++ b/gdb/gdbsupport/common-utils.h
@@ -110,10 +110,9 @@ 
 
 extern char *safe_strerror (int);
 
-/* Return non-zero if the start of STRING matches PATTERN, zero
-   otherwise.  */
+/* Return true if the start of STRING matches PATTERN, false otherwise.  */
 
-static inline int
+static inline bool
 startswith (const char *string, const char *pattern)
 {
   return strncmp (string, pattern, strlen (pattern)) == 0;