Patchwork [review] Fix typo in symfile.c

login
register
mail settings
Submitter Simon Marchi (Code Review)
Date Oct. 19, 2019, 5:01 a.m.
Message ID <gerrit.1571461310000.I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4@gnutoolchain-gerrit.osci.io>
Download mbox | patch
Permalink /patch/35153/
State New
Headers show

Comments

Simon Marchi (Code Review) - Oct. 19, 2019, 5:01 a.m.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................

Fix typo in symfile.c

This commit fixes a simple typo in gdb/symfile.c.  s/wether/whether/.

2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>

	* symfile.c (init_entry_point_info): Fix typo.

Change-Id: I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4
---
M gdb/symfile.c
1 file changed, 1 insertion(+), 1 deletion(-)
Simon Marchi (Code Review) - Oct. 19, 2019, 5:06 a.m.
Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................


Patch Set 1:

(1 comment)

This is a test.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161/1/gdb/symfile.c 
File gdb/symfile.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161/1/gdb/symfile.c@911 
PS1, Line 911:    an extra symbol file such as dynamically loaded code, and whether
Test comment while there's only v1.
Simon Marchi (Code Review) - Oct. 19, 2019, 5:07 a.m.
Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................


Patch Set 2:

(1 comment)

This is a test comment.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161/1/gdb/symfile.c 
File gdb/symfile.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161/1/gdb/symfile.c@911 
PS1, Line 911:    an extra symbol file such as dynamically loaded code, and whether
> Test comment while there's only v1.
Test comment in v1 after v2 has been uploaded.
Simon Marchi (Code Review) - Oct. 19, 2019, 5:11 a.m.
Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................


Patch Set 2: Code-Review+2
Simon Marchi (Code Review) - Oct. 23, 2019, 5 p.m.
Sergio Durigan Junior has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................


Patch Set 3:

This is a test comment.
Simon Marchi (Code Review) - Oct. 23, 2019, 10 p.m.
Sergio Durigan Junior has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................


Patch Set 3:

This is another test comment.


Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4
Gerrit-Change-Number: 161
Gerrit-PatchSet: 3
Gerrit-Owner: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-Reviewer: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 23 Oct 2019 22:00:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Simon Marchi (Code Review) - Oct. 23, 2019, 10:02 p.m.
Sergio Durigan Junior has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................


Patch Set 3:

On Wednesday, October 23 2019, Sergio Durigan Junior wrote:

And this is a test reply, sent by e-mail.


Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4
Gerrit-Change-Number: 161
Gerrit-PatchSet: 3
Gerrit-Owner: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-Reviewer: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 23 Oct 2019 22:02:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Simon Marchi (Code Review) - Oct. 25, 2019, 1:58 a.m.
Sergio Durigan Junior has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................


Patch Set 3:

This is a change with a very long line that doesn't wrap here but should wrap automatically in the email message when gerrit sends it through the SMTP server configured in the config file, yes.

Patch

diff --git a/gdb/symfile.c b/gdb/symfile.c
index 82081b1..f74c6de 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -908,7 +908,7 @@ 
    corresponding BFD section index, or -1 if the section was not found.
 
    ADD_FLAGS encodes verbosity level, whether this is main symbol or
-   an extra symbol file such as dynamically loaded code, and wether
+   an extra symbol file such as dynamically loaded code, and whether
    breakpoint reset should be deferred.  */
 
 static void