From patchwork Fri Oct 18 13:53:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35142 Received: (qmail 123753 invoked by alias); 18 Oct 2019 14:02:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 123739 invoked by uid 89); 18 Oct 2019 14:02:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Oct 2019 14:02:52 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 1C64B20969; Fri, 18 Oct 2019 09:53:29 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 9B2C220961 for ; Fri, 18 Oct 2019 09:53:24 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 7A9D32192A for ; Fri, 18 Oct 2019 09:53:24 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Fri, 18 Oct 2019 09:53:24 -0400 From: "Tankut Baris Aktemur (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] infcall: remove unused parameter in 'value_arg_coerce' X-Gerrit-Change-Id: If324a1dda3fa5d4c145790b92bd3f656c00296f4 X-Gerrit-Change-Number: 140 X-Gerrit-ChangeURL: X-Gerrit-Commit: 67619560f5019a7af3927cf6187ee3d8ff92f2c5 References: Reply-To: tankut.baris.aktemur@intel.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3 Tankut Baris Aktemur has uploaded a new change for review. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/140 ...................................................................... infcall: remove unused parameter in 'value_arg_coerce' Remove the unused SP parameter from the auxiliary function 'value_arg_coerce'. gdb/ChangeLog: 2019-MM-DD Tankut Baris Aktemur * infcall.c (value_arg_coerce): Remove an unused parameter. (call_function_by_hand_dummy): Update the call to 'value_arg_coerce'. Change-Id: If324a1dda3fa5d4c145790b92bd3f656c00296f4 --- M gdb/infcall.c 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/gdb/infcall.c b/gdb/infcall.c index 629a83c..288b9e0 100644 --- a/gdb/infcall.c +++ b/gdb/infcall.c @@ -145,13 +145,11 @@ for arguments to be passed to C, Ada or Fortran functions. If PARAM_TYPE is non-NULL, it is the expected parameter type. - IS_PROTOTYPED is non-zero if the function declaration is prototyped. - SP is the stack pointer were additional data can be pushed (updating - its value as needed). */ + IS_PROTOTYPED is non-zero if the function declaration is prototyped. */ static struct value * value_arg_coerce (struct gdbarch *gdbarch, struct value *arg, - struct type *param_type, int is_prototyped, CORE_ADDR *sp) + struct type *param_type, int is_prototyped) { const struct builtin_type *builtin = builtin_type (gdbarch); struct type *arg_type = check_typedef (value_type (arg)); @@ -1020,7 +1018,7 @@ param_type = NULL; args[i] = value_arg_coerce (gdbarch, args[i], - param_type, prototyped, &sp); + param_type, prototyped); if (param_type != NULL && !(language_pass_by_reference (param_type).trivially_copyable))