| Message ID | 87k193w4c4.fsf@oldenburg2.str.redhat.com |
|---|---|
| State | Committed |
| Headers |
Received: (qmail 81175 invoked by alias); 17 Oct 2019 19:37:53 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 81161 invoked by uid 89); 17 Oct 2019 19:37:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS, T_FILL_THIS_FORM_SHORT autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com From: Florian Weimer <fweimer@redhat.com> To: Joseph Myers <joseph@codesourcery.com> Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>, <libc-alpha@sourceware.org>, "Paul A . Clarke" <pc@us.ibm.com> Subject: Re: [PATCH 2/3] sysvipc: Implement semop based on semtimedop References: <20191011191554.10870-1-adhemerval.zanella@linaro.org> <20191011191554.10870-2-adhemerval.zanella@linaro.org> <878spl6mfe.fsf@oldenburg2.str.redhat.com> <alpine.DEB.2.21.1910171927330.16239@digraph.polyomino.org.uk> Date: Thu, 17 Oct 2019 21:37:47 +0200 In-Reply-To: <alpine.DEB.2.21.1910171927330.16239@digraph.polyomino.org.uk> (Joseph Myers's message of "Thu, 17 Oct 2019 19:31:00 +0000") Message-ID: <87k193w4c4.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain |
Commit Message
Florian Weimer
Oct. 17, 2019, 7:37 p.m. UTC
* Joseph Myers: > I'm seeing a build failure for i686-gnu I suspect is caused by this > change. > > In file included from <command-line>: > ./../include/libc-symbols.h:545:33: error: '__EI___semtimedop' aliased to undefined symbol '__GI___semtimedop' > extern thread __typeof (name) __EI_##name \ > ^~~~~ > ./../include/libc-symbols.h:541:3: note: in expansion of macro '__hidden_ver2' > __hidden_ver2 (, local, internal, name) > ^~~~~~~~~~~~~ > ./../include/libc-symbols.h:550:29: note: in expansion of macro '__hidden_ver1' > # define hidden_def(name) __hidden_ver1(__GI_##name, name, name); > ^~~~~~~~~~~~~ > ./../include/libc-symbols.h:619:32: note: in expansion of macro 'hidden_def' > # define libc_hidden_def(name) hidden_def (name) > ^~~~~~~~~~ > semtimedop.c:32:1: note: in expansion of macro 'libc_hidden_def' > libc_hidden_def (__semtimedop) > ^~~~~~~~~~~~~~~ > > https://sourceware.org/ml/libc-testresults/2019-q4/msg00085.html This should fix it. Thanks, Florian 8<------------------------------------------------------------------8< Subject: Remove libc_hidden_def from __semtimedop stub This breaks the Hurd build after commit 765cdd0bffd77960ae852104f ("sysvipc: Implement semop based on semtimedop") added it to the stub. ----- sysvipc/semtimedop.c | 1 - 1 file changed, 1 deletion(-)
Comments
On Thu, 17 Oct 2019, Florian Weimer wrote: > This should fix it. > > Thanks, > Florian > > 8<------------------------------------------------------------------8< > Subject: Remove libc_hidden_def from __semtimedop stub > > This breaks the Hurd build after commit 765cdd0bffd77960ae852104f > ("sysvipc: Implement semop based on semtimedop") added it to the stub. Thanks, please commit.
On 17/10/2019 16:37, Florian Weimer wrote: > * Joseph Myers: > >> I'm seeing a build failure for i686-gnu I suspect is caused by this >> change. >> >> In file included from <command-line>: >> ./../include/libc-symbols.h:545:33: error: '__EI___semtimedop' aliased to undefined symbol '__GI___semtimedop' >> extern thread __typeof (name) __EI_##name \ >> ^~~~~ >> ./../include/libc-symbols.h:541:3: note: in expansion of macro '__hidden_ver2' >> __hidden_ver2 (, local, internal, name) >> ^~~~~~~~~~~~~ >> ./../include/libc-symbols.h:550:29: note: in expansion of macro '__hidden_ver1' >> # define hidden_def(name) __hidden_ver1(__GI_##name, name, name); >> ^~~~~~~~~~~~~ >> ./../include/libc-symbols.h:619:32: note: in expansion of macro 'hidden_def' >> # define libc_hidden_def(name) hidden_def (name) >> ^~~~~~~~~~ >> semtimedop.c:32:1: note: in expansion of macro 'libc_hidden_def' >> libc_hidden_def (__semtimedop) >> ^~~~~~~~~~~~~~~ >> >> https://sourceware.org/ml/libc-testresults/2019-q4/msg00085.html > > This should fix it. > > Thanks, > Florian > > 8<------------------------------------------------------------------8< > Subject: Remove libc_hidden_def from __semtimedop stub > > This breaks the Hurd build after commit 765cdd0bffd77960ae852104f > ("sysvipc: Implement semop based on semtimedop") added it to the stub. > > ----- > sysvipc/semtimedop.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sysvipc/semtimedop.c b/sysvipc/semtimedop.c > index 68707d6ade..a4b750c813 100644 > --- a/sysvipc/semtimedop.c > +++ b/sysvipc/semtimedop.c > @@ -29,6 +29,5 @@ __semtimedop (int semid, struct sembuf *sops, size_t nsops, > return -1; > } > weak_alias (__semtimedop, semtimedop) > -libc_hidden_def (__semtimedop) > > stub_warning (semtimedop) > Ugh, I though I removed it from last iteration, thanks for catching it.
diff --git a/sysvipc/semtimedop.c b/sysvipc/semtimedop.c index 68707d6ade..a4b750c813 100644 --- a/sysvipc/semtimedop.c +++ b/sysvipc/semtimedop.c @@ -29,6 +29,5 @@ __semtimedop (int semid, struct sembuf *sops, size_t nsops, return -1; } weak_alias (__semtimedop, semtimedop) -libc_hidden_def (__semtimedop) stub_warning (semtimedop)