From patchwork Thu Oct 17 10:33:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Kilroy X-Patchwork-Id: 35090 Received: (qmail 57560 invoked by alias); 17 Oct 2019 10:33:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 57474 invoked by uid 89); 17 Oct 2019 10:33:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xcum8Zg9CSNnsbl8AxSTWmx4Wev2HJBiGCYHAg6Fitc=; b=UuSnvrckGlqpcsNv2S98OxFHqreFYS8iESn4c3jYvA1ennW0bA0rieSz3CE6OiSerXxbSlIA41nEk8sejV73JHOBFhFEt5MbP7d7GLla86gH6zeFkGrK1yyMTi6cqF6wdex45ct+0B7uKNfX61Dop/5EK/UWZXWij1xOGZ4vuio= Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; sourceware.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) X-CheckRecipientChecked: true X-CR-MTA-CID: 42f480caedb36fba X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R3lfYOOd+c0O5bz9kBj5Rh7qdf7pGQOlbZRcXzje0cjQqCNeJi6CJbgBi0KyAGYGR4mGUNDHEXUvnTezS/cypGhBm52/Y6uuiqbFLfzpQOBFEqQPMvyE+SZ9OP9iXzAw1cflB/HbubyoTMFGUu0RWi3DhyP3ywREGAAE8kqMkD8rtbfGpBcF+530mC7sWVIsLxDTS5zoHatIfVPoIlTurV+aR9jzrZCME77W+f9jZhQDobPEglnoYk/dFdqVWPPcrg95eC0JsU+9YCMKAUDc+LyKj2l3gd85LhuSDPB7IP5QkkGgyxrp3wI4pqjG+pMk2pfKLG/6Vm/d+Q9ypZXjGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xcum8Zg9CSNnsbl8AxSTWmx4Wev2HJBiGCYHAg6Fitc=; b=P57y05FIlB+HB7eQ/9YOZrCgjluo+GBuaER3nCMZMKbCRnH6dUkMOsDfz9htmtt8nqWjCIqn49d5hkxc2Lfm72cPmFgMhuRMMDTVoIwpTgEV5/PLztlan6RwlFzcVX1sX0WsuH9KZwBan1OYX6VX2RQQUDFdmIQujTqepNOqOP+boalWfKCUg7G7aeDbmMGBwh67GkzQjH9Fu3VvZYzZgnPLbO8plgo5f08yYRXamlqjbIaRSCBW9qMLdQMTTANcIHW6CclecYb1i/rhkDktyXz11569EEy5EguHHx0MiGfCcL/jb3maji5Jt6Eol9S0SrYIJGYemulV+6NsTutCkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xcum8Zg9CSNnsbl8AxSTWmx4Wev2HJBiGCYHAg6Fitc=; b=UuSnvrckGlqpcsNv2S98OxFHqreFYS8iESn4c3jYvA1ennW0bA0rieSz3CE6OiSerXxbSlIA41nEk8sejV73JHOBFhFEt5MbP7d7GLla86gH6zeFkGrK1yyMTi6cqF6wdex45ct+0B7uKNfX61Dop/5EK/UWZXWij1xOGZ4vuio= From: David Kilroy To: "libc-alpha@sourceware.org" CC: nd Subject: [PATCH 2/3] elf: avoid redundant sort in dlopen Date: Thu, 17 Oct 2019 10:33:19 +0000 Message-ID: <6809187033c7c9d0cc9689e1eb05a18bf0fd31c2.1571301957.git.david.kilroy@arm.com> References: In-Reply-To: Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=David.Kilroy@arm.com; x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:4125;OLM:4125; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(376002)(366004)(136003)(39860400002)(396003)(346002)(189003)(199004)(7736002)(305945005)(64756008)(99286004)(478600001)(66946007)(36756003)(102836004)(66446008)(66556008)(6512007)(26005)(186003)(386003)(4744005)(66476007)(11346002)(5640700003)(446003)(71200400001)(2501003)(44832011)(486006)(2616005)(5660300002)(476003)(52116002)(8676002)(71190400001)(66066001)(76176011)(4326008)(6506007)(6436002)(86362001)(8936002)(3846002)(25786009)(6116002)(118296001)(14454004)(81166006)(6916009)(6486002)(316002)(256004)(81156014)(14444005)(2906002)(50226002)(2351001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB5492; H:AM0PR08MB4068.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DKYhurZz/gzgIv1l66Y06FVJXLk0zz824SFffZ0BEA9Zb6Rl9BWdcCUz8iFczgotSHxrLvKf/hkZF8YtoSqQ02O4F6fe4KnaW0CjzUlLwTiKXw0U5k+eUNQGjz7OJayg7xFZTMUeuPnnC9tEVEEo2D1Y/leawsP5W650qjgTi64RtZAO6vWagp5EbWHtfKh7nfujgn2DvsrCkN+ylfwOFjzoskaSaB/Zyig0sav0S5vNwM7562YYloeQLerl7BMnJnpvq5J5qS5p3Sjnh1yJ6pYSY7m3fXHsW7g0zH+/c1cSJMz396lqKAj921AHXJhAwHNNuEFV5LERR1usCcl10HrbnFnhBhIYnmx1+UPnxb7R2oDBz9tBpf0ZxDoCp57UTiir8fzhn6xkOi1ncKRB+d0Cgz6DlloWWxFSw5UmNUo= x-ms-exchange-transport-forked: True MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Kilroy@arm.com; Return-Path: David.Kilroy@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 757cc761-454c-4a36-9fd8-08d752ed6d73 l_initfini is already sorted by dependency in _dl_map_object_deps(), so avoid sorting again in dl_open_worker(). Tested by running the testsuite on x86_64. --- elf/dl-open.c | 1 - 1 file changed, 1 deletion(-) diff --git a/elf/dl-open.c b/elf/dl-open.c index 7fcfdc0..25e8fb0 100644 --- a/elf/dl-open.c +++ b/elf/dl-open.c @@ -326,7 +326,6 @@ dl_open_worker (void *a) l = new->l_initfini[++j]; } while (l != NULL); - _dl_sort_maps (maps, nmaps, NULL, false); int relocation_in_progress = 0;