Patchwork [2/3] elf: avoid redundant sort in dlopen

login
register
mail settings
Submitter David Kilroy
Date Oct. 17, 2019, 10:33 a.m.
Message ID <6809187033c7c9d0cc9689e1eb05a18bf0fd31c2.1571301957.git.david.kilroy@arm.com>
Download mbox | patch
Permalink /patch/35090/
State New
Headers show

Comments

David Kilroy - Oct. 17, 2019, 10:33 a.m.
l_initfini is already sorted by dependency in _dl_map_object_deps(),
so avoid sorting again in dl_open_worker().

Tested by running the testsuite on x86_64.
---
 elf/dl-open.c | 1 -
 1 file changed, 1 deletion(-)

Patch

diff --git a/elf/dl-open.c b/elf/dl-open.c
index 7fcfdc0..25e8fb0 100644
--- a/elf/dl-open.c
+++ b/elf/dl-open.c
@@ -326,7 +326,6 @@  dl_open_worker (void *a)
       l = new->l_initfini[++j];
     }
   while (l != NULL);
-  _dl_sort_maps (maps, nmaps, NULL, false);
 
   int relocation_in_progress = 0;