From patchwork Thu Oct 10 13:35:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Brauner X-Patchwork-Id: 34909 Received: (qmail 32782 invoked by alias); 10 Oct 2019 15:24:26 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 32650 invoked by uid 89); 10 Oct 2019 15:24:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_SBL_CSS, RCVD_IN_SORBS_WEB autolearn=unavailable version=3.3.1 spammy=HReceived-SPF:pass, HX-Google-DKIM-Signature:sk:x-origi, HX-Original-Authentication-Results:spf, HX-Original-Authentication-Results:permitted X-HELO: youngberry.canonical.com Resent-From: Christian Brauner Resent-Date: Thu, 10 Oct 2019 17:24:00 +0200 Resent-Message-ID: <20191010152400.563fhfv65akvwa4i@wittgenstein> Resent-To: libc-alpha@sourceware.org ARC-Seal: i=2; a=rsa-sha256; t=1570714608; cv=pass; d=google.com; s=arc-20160816; b=ZWIQoSEOmOg1I6u3R1MivFfVHC/otpVbIdOPunaQxDct/QynSfs0AbQXBiEUZgNnfl 9JcHMe8oihE8JfvAompTxs6Q3VqS48dciHYwf0OmM3Sq6haResFkIQyaRc+wOMWWOKf0 NIZV5RWzt+hrmAo8jmd4LcA1nMla8BB4wNdyNEIW8O1iDdn0udgYjCDsa0Dj4USGlY0q Ur9WJ82e/YqldSD+vYv1sn/q/U+6PouGgl0TYG+tmdOLq8GU7h4eA4AoYc2jktVSwhYN oFiq+5ZuyE5gapJ6Q6e9uW1pPdliHndP0+6xBJxF8/bkSGWdwQNF7XGBvQS4DMLyyahj 4tBQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:delivered-to; bh=ojv6YG6RITwlcY5aroAxXtMlkW/FY86TUJN6zaSvQas=; b=j8mrKajqfVfiX/PqTM+TLUm6/2p9UllFgjOtDoWYRuiInuNBne3DghlRP8ifHXXDut b+MU47wuMF0ivEQXdpnNbCOw8MP//0cG82i1HxJcMqEjBSfaWBASuVYUR1SLdWBR+1cu UPH49G/WnqnZU9KevdoufSELrU8iPMDekzv0kATnR4I63R+zpIgiUkdkN+zO9nyjCD50 YuuUT8nHyOVQhA6ecsojIPYRc5euj7MU7n1h58OOfyO8eMxmj7878U9J/2usUCW/Oe2/ t85sdtxY+TMTs9iM0EAUkL3OplWApcBd/tobdP1RMg8ibez8YLNaPfy6mP3gPjb082Am GVCw== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: best guess record for domain of christian.brauner+caf_=christian=brauner.io@canonical.com designates 91.189.89.112 as permitted sender) smtp.mailfrom="christian.brauner+caf_=christian=brauner.io@canonical.com" Received-SPF: pass (google.com: best guess record for domain of christian.brauner+caf_=christian=brauner.io@canonical.com designates 91.189.89.112 as permitted sender) client-ip=91.189.89.112; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: best guess record for domain of christian.brauner+caf_=christian=brauner.io@canonical.com designates 91.189.89.112 as permitted sender) smtp.mailfrom="christian.brauner+caf_=christian=brauner.io@canonical.com" X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 91.189.89.112 is neither permitted nor denied by best guess record for domain of christian.brauner@ubuntu.com) smtp.mailfrom=christian.brauner@ubuntu.com X-Forwarded-To: christian@brauner.io X-Forwarded-For: christian.brauner@canonical.com christian@brauner.io ARC-Seal: i=1; a=rsa-sha256; t=1570714605; cv=none; d=google.com; s=arc-20160816; b=PwyZdd9b18tlnDd+20kPV+Dn7rlsNQojmYbugHWbdaRw0SzUZsMzCyA97xH0kyjKOC WMAJ1Wr9KYU4pByG6eUqCrBGFgLUqxQ7ouAyvKtQHesAULejtT80NxNGRnkPIN57+BV0 sKi5B4791C+xSZakbN/S3oFV/pIcUEG5D2rkkcq9xI2HW3hMGzaV7LbvaV8Lp/YtmxCY AJ4UZk1lJpiKVnaZrdTDt7iw+MlesD9ye438xQlz9MtlHSPfUW2f/wJwzp3coKn3JYlJ w9CN/nt+lB/6cUfN+NpvMpsBLMeiTTAjeIXpEdayEk+/xB9o+fJ4UGuEF0teL3dNYLRg HCZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=ojv6YG6RITwlcY5aroAxXtMlkW/FY86TUJN6zaSvQas=; b=lbolqUsuByo5Rp2KYVByv6vRfq2TFfGil2k7u+ZMBX5H7D1N2b1BC5wV7riRMWo1vF kCV7vZtXBBiI1aIrNLU+MZbCppz1h6yPZJHoGSoZ/QflexphSZa6KuturHNT25APW8A9 Q5LD4TxUBfQejo2eErMO70gmXzRopQEDYtqqW/xb1IPvaz0w+IH/eLB3pHaYtVDVW5H8 prUKG9QZaRIJTMoRtk+nNqNqUtfk1rQ136TIRxZ3gN+D2oJRKIOiketBFCXbhCDwXeQ+ V+u4ukzbC6Y+nMJpSAJSaXonPzu3gABKAA8jYngq/UOnaFogiquUPjNbHR5zL3sgpYMk Jslg== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 91.189.89.112 is neither permitted nor denied by best guess record for domain of christian.brauner@ubuntu.com) smtp.mailfrom=christian.brauner@ubuntu.com Received-SPF: neutral (google.com: 91.189.89.112 is neither permitted nor denied by best guess record for domain of christian.brauner@ubuntu.com) client-ip=91.189.89.112; From: Christian Brauner To: linux-kernel@vger.kernel.org, Oleg Nesterov , Florian Weimer , libc-alpha@sourceware.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Shuah Khan , Andrew Morton , Michal Hocko , Elena Reshetova , Thomas Gleixner , Roman Gushchin , Andrea Arcangeli , Al Viro , Aleksa Sarai , "Dmitry V. Levin" , linux-kselftest@vger.kernel.org, Christian Brauner Subject: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND Date: Thu, 10 Oct 2019 15:35:17 +0200 Message-Id: <20191010133518.5420-1-christian.brauner@ubuntu.com> MIME-Version: 1.0 Reset all signal handlers of the child not set to SIG_IGN to SIG_DFL. Mutually exclusive with CLONE_SIGHAND to not disturb other thread's signal handler. In the spirit of closer cooperation between glibc developers and kernel developers (cf. [2]) this patchset came out of a discussion on the glibc mailing list for improving posix_spawn() (cf. [1], [3], [4]). Kernel support for this feature has been explicitly requested by glibc and I see no reason not to help them with this. The child helper process on Linux posix_spawn must ensure that no signal handlers are enabled, so the signal disposition must be either SIG_DFL or SIG_IGN. However, it requires a sigprocmask to obtain the current signal mask and at least _NSIG sigaction calls to reset the signal handlers for each posix_spawn call or complex state tracking that might lead to data corruption in glibc. Adding this flags lets glibc avoid these problems. [1]: https://www.sourceware.org/ml/libc-alpha/2019-10/msg00149.html [3]: https://www.sourceware.org/ml/libc-alpha/2019-10/msg00158.html [4]: https://www.sourceware.org/ml/libc-alpha/2019-10/msg00160.html [2]: https://lwn.net/Articles/799331/ '[...] by asking for better cooperation with the C-library projects in general. They should be copied on patches containing ABI changes, for example. I noted that there are often times where C-library developers wish the kernel community had done things differently; how could those be avoided in the future? Members of the audience suggested that more glibc developers should perhaps join the linux-api list. The other suggestion was to "copy Florian on everything".' Cc: Oleg Nesterov Cc: Florian Weimer Cc: libc-alpha@sourceware.org Signed-off-by: Christian Brauner --- include/uapi/linux/sched.h | 3 +++ kernel/fork.c | 11 ++++++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h index 99335e1f4a27..c583720f689f 100644 --- a/include/uapi/linux/sched.h +++ b/include/uapi/linux/sched.h @@ -33,6 +33,9 @@ #define CLONE_NEWNET 0x40000000 /* New network namespace */ #define CLONE_IO 0x80000000 /* Clone io context */ +/* Flags for the clone3() syscall */ +#define CLONE3_CLEAR_SIGHAND 0x100000000ULL /* Clear any signal handler and reset to SIG_DFL. */ + #ifndef __ASSEMBLY__ /** * struct clone_args - arguments for the clone3 syscall diff --git a/kernel/fork.c b/kernel/fork.c index 1f6c45f6a734..661f8d1f3881 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -1517,6 +1517,11 @@ static int copy_sighand(unsigned long clone_flags, struct task_struct *tsk) spin_lock_irq(¤t->sighand->siglock); memcpy(sig->action, current->sighand->action, sizeof(sig->action)); spin_unlock_irq(¤t->sighand->siglock); + + /* Reset all signal handler not set to SIG_IGN to SIG_DFL. */ + if (clone_flags & CLONE3_CLEAR_SIGHAND) + flush_signal_handlers(tsk, 0); + return 0; } @@ -2567,7 +2572,7 @@ static bool clone3_args_valid(const struct kernel_clone_args *kargs) * All lower bits of the flag word are taken. * Verify that no other unknown flags are passed along. */ - if (kargs->flags & ~CLONE_LEGACY_FLAGS) + if (kargs->flags & ~(CLONE_LEGACY_FLAGS | CLONE3_CLEAR_SIGHAND)) return false; /* @@ -2577,6 +2582,10 @@ static bool clone3_args_valid(const struct kernel_clone_args *kargs) if (kargs->flags & (CLONE_DETACHED | CSIGNAL)) return false; + if ((kargs->flags & (CLONE_SIGHAND | CLONE3_CLEAR_SIGHAND)) == + (CLONE_SIGHAND | CLONE3_CLEAR_SIGHAND)) + return false; + if ((kargs->flags & (CLONE_THREAD | CLONE_PARENT)) && kargs->exit_signal) return false;