Move declaration of varobjdebug to header
Commit Message
From: Christian Biesinger <cbiesinger@google.com>
gdb/ChangeLog:
2019-10-09 Christian Biesinger <cbiesinger@google.com>
* mi/mi-cmd-var.c (varobjdebug): Remove declaration.
* varobj.c (varobjdebug): Move comment to...
* varobj.h (varobjdebug): ...here, and declare.
---
gdb/mi/mi-cmd-var.c | 2 --
gdb/varobj.c | 2 +-
gdb/varobj.h | 5 +++++
3 files changed, 6 insertions(+), 3 deletions(-)
Comments
>>>>> "cbiesinger" == cbiesinger <cbiesinger@chromium.org> writes:
> 2019-10-09 Christian Biesinger <cbiesinger@google.com>
> * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
> * varobj.c (varobjdebug): Move comment to...
> * varobj.h (varobjdebug): ...here, and declare.
Ok, thanks.
Tom
On Thu, Oct 10, 2019 at 7:56 AM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "cbiesinger" == cbiesinger <cbiesinger@chromium.org> writes:
>
> > 2019-10-09 Christian Biesinger <cbiesinger@google.com>
>
> > * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
> > * varobj.c (varobjdebug): Move comment to...
> > * varobj.h (varobjdebug): ...here, and declare.
>
> Ok, thanks.
Thanks, pushed.
To ssh://sourceware.org/git/binutils-gdb.git
6dfc0041129..c2c440a9038 HEAD -> master
Christian
@@ -33,8 +33,6 @@
#include "gdbsupport/gdb_optional.h"
#include "inferior.h"
-extern unsigned int varobjdebug; /* defined in varobj.c. */
-
static void varobj_update_one (struct varobj *var,
enum print_values print_values,
bool is_explicit);
@@ -40,7 +40,7 @@
typedef int PyObject;
#endif
-/* Non-zero if we want to see trace of varobj level stuff. */
+/* See varobj.h. */
unsigned int varobjdebug = 0;
static void
@@ -235,6 +235,11 @@ extern const struct lang_varobj_ops cplus_varobj_ops;
extern const struct lang_varobj_ops ada_varobj_ops;
#define default_varobj_ops c_varobj_ops
+
+/* Non-zero if we want to see trace of varobj level stuff. */
+
+extern unsigned int varobjdebug;
+
/* API functions */
extern struct varobj *varobj_create (const char *objname,