Patchwork Move declaration of overload_debug to header

login
register
mail settings
Submitter Doug Evans via gdb-patches
Date Oct. 7, 2019, 7:42 p.m.
Message ID <20191007194226.69885-1-cbiesinger@google.com>
Download mbox | patch
Permalink /patch/34857/
State New
Headers show

Comments

Doug Evans via gdb-patches - Oct. 7, 2019, 7:42 p.m.
gdb/ChangeLog:

2019-10-07  Christian Biesinger  <cbiesinger@google.com>

	* gdbtypes.c (overload_debug): Move comment to header.
	* gdbtypes.h (overload_debug): Declare.
	* valops.c: Remove declaration of overload_debug, instead
	include gdbtypes.h.
---
 gdb/gdbtypes.c | 3 +--
 gdb/gdbtypes.h | 5 +++++
 gdb/valops.c   | 2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)
Tom Tromey - Oct. 8, 2019, 12:47 p.m.
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:

Christian> gdb/ChangeLog:
Christian> 2019-10-07  Christian Biesinger  <cbiesinger@google.com>

Christian> 	* gdbtypes.c (overload_debug): Move comment to header.
Christian> 	* gdbtypes.h (overload_debug): Declare.
Christian> 	* valops.c: Remove declaration of overload_debug, instead
Christian> 	include gdbtypes.h.

Ok.  Thank you.

Tom
Doug Evans via gdb-patches - Oct. 8, 2019, 3:17 p.m.
On Tue, Oct 8, 2019 at 7:47 AM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Christian> gdb/ChangeLog:
> Christian> 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
>
> Christian>      * gdbtypes.c (overload_debug): Move comment to header.
> Christian>      * gdbtypes.h (overload_debug): Declare.
> Christian>      * valops.c: Remove declaration of overload_debug, instead
> Christian>      include gdbtypes.h.
>
> Ok.  Thank you.

Thanks, pushed.

To ssh://sourceware.org/git/binutils-gdb.git
   34916edc47..79bb1944d6  HEAD -> master

Christian

Patch

diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index afda89e43f..a2b81c8690 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -118,8 +118,7 @@  const struct floatformat *floatformats_ibm_long_double[BFD_ENDIAN_UNKNOWN] = {
 
 static bool opaque_type_resolution = true;
 
-/* A flag to enable printing of debugging information of C++
-   overloading.  */
+/* See gdbtypes.h.  */
 
 unsigned int overload_debug = 0;
 
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index c62b8a31ba..d431cb6fdd 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -2146,4 +2146,9 @@  extern int type_not_allocated (const struct type *type);
 
 extern int type_not_associated (const struct type *type);
 
+/* A flag to enable printing of debugging information of C++
+   overloading.  */
+
+extern unsigned int overload_debug;
+
 #endif /* GDBTYPES_H */
diff --git a/gdb/valops.c b/gdb/valops.c
index fc7a4c5918..4c8efd90fb 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -39,9 +39,9 @@ 
 #include "observable.h"
 #include "objfiles.h"
 #include "extension.h"
+#include "gdbtypes.h"
 #include "gdbsupport/byte-vector.h"
 
-extern unsigned int overload_debug;
 /* Local functions.  */
 
 static int typecmp (int staticp, int varargs, int nargs,