From patchwork Fri Oct 4 14:26:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 34828 Received: (qmail 110034 invoked by alias); 4 Oct 2019 14:26:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 110026 invoked by uid 89); 4 Oct 2019 14:26:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, SPF_PASS autolearn=ham version=3.3.1 spammy=sk:DW_AT_s, sk:dw_at_s, S_M_s_var_int, s_m_s_var_int X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 Oct 2019 14:26:21 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3446DB07B for ; Fri, 4 Oct 2019 14:26:19 +0000 (UTC) Date: Fri, 4 Oct 2019 16:26:17 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH][gdb/testsuite] Fix local-static.exp with g++-4.8 Message-ID: <20191004142616.GA11097@delia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes Hi, With g++-4.8, I see: ... (gdb) PASS: gdb.cp/local-static.exp: c++: print free_inline_func(void) print 'S::method()'::S_M_s_var_int^M No symbol "S_M_s_var_int" in specified context.^M (gdb) FAIL: gdb.cp/local-static.exp: c++: print 'S::method()'::S_M_s_var_int ... The variable is declared like this (showing pruned .ii): ... void S::method () { static int S_M_s_var_int = 4; } ... But the DWARF generated for the variable is encapsulated in an unnamed lexical block: ... <1><121>: Abbrev Number: 5 (DW_TAG_structure_type) <122> DW_AT_name : S ... <2><14f>: Abbrev Number: 6 (DW_TAG_subprogram) ... <150> DW_AT_name : (indirect string, offset: 0x599): method <156> DW_AT_linkage_name: (indirect string, offset: 0x517): \ _ZN1S6methodEv /* demangled: dS::method() */ ... <1><3f8>: Abbrev Number: 21 (DW_TAG_subprogram) <3f9> DW_AT_specification: <0x14f> ... <3fe> DW_AT_low_pc : 0x4004fc <406> DW_AT_high_pc : 0x2c /* 0x400528 */ ... <2><418>: Abbrev Number: 17 (DW_TAG_formal_parameter) <419> DW_AT_name : (indirect string, offset: 0x68a): this ... <2><424>: Abbrev Number: 18 (DW_TAG_lexical_block) <425> DW_AT_low_pc : 0x400508 <42d> DW_AT_high_pc : 0x1e /* 0x400526 */ <3><435>: Abbrev Number: 22 (DW_TAG_variable) <436> DW_AT_name : (indirect string, offset: 0x29d): S_M_s_var_int ... which has the effect that the variable is not addressable unless the program counter is in the range of the lexical block. This is caused by gcc PR debug/55541, which was fixed in gcc 5. Mark in total 225 FAILs as XFAIL. Tested on x86_64-linux. OK for trunk? Thanks, - Tom [gdb/testsuite] Fix local-static.exp with g++-4.8 gdb/testsuite/ChangeLog: 2019-10-04 Tom de Vries * gdb.cp/local-static.exp (do_test): Add xfails for gcc PR debug/55541. --- gdb/testsuite/gdb.cp/local-static.exp | 40 ++++++++++++++++++++++++++++++++--- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.cp/local-static.exp b/gdb/testsuite/gdb.cp/local-static.exp index fe0e2dc0f3a..9905ffb7948 100644 --- a/gdb/testsuite/gdb.cp/local-static.exp +++ b/gdb/testsuite/gdb.cp/local-static.exp @@ -130,6 +130,7 @@ proc do_test {lang} { global cxx_scopes_list global vars_list global srcfile testfile + global gdb_prompt set options {debug} @@ -201,12 +202,45 @@ proc do_test {lang} { set var [lindex $var_line 0] set print_re [lindex $var_line 1] - gdb_test "print '${scope}'::${var_prefix}_${var}" $print_re - gdb_test "print ${scope}::${var_prefix}_${var}" $print_re + # The gcc PR debug/55541 has the effect that local statics are + # wrapped in a DW_TAG_lexical_block, making them unaddressable from + # outside the function. XFAIL the relevant tests. + set test "print '${scope}'::${var_prefix}_${var}" + set xfail_pattern "No symbol \".*\" in specified context." + gdb_test_multiple $test $test { + -re "\[\r\n\]*(?:$print_re)\[\r\n\]+$gdb_prompt $" { + pass $test + } + -re "\[\r\n\]*(?:$xfail_pattern)\[\r\n\]+$gdb_prompt $" { + xfail $test + } + } + set test "print ${scope}::${var_prefix}_${var}" + gdb_test_multiple $test $test { + -re "\[\r\n\]*(?:$print_re)\[\r\n\]+$gdb_prompt $" { + pass $test + } + -re "\[\r\n\]*(?:$xfail_pattern)\[\r\n\]+$gdb_prompt $" { + xfail $test + } + } set sym "${scope}::${var_prefix}_${var}" if {$lang == "c++"} { - gdb_test "print '${sym}'" $print_re + set test "print '${sym}'" + set xfail_pattern "No symbol .* in current context." + set xfail_pattern2 "has unknown type; cast it to its declared type" + gdb_test_multiple $test $test { + -re "\[\r\n\]*(?:$print_re)\[\r\n\]+$gdb_prompt $" { + pass $test + } + -re "\[\r\n\]*(?:$xfail_pattern)\[\r\n\]+$gdb_prompt $" { + xfail $test + } + -re "\[\r\n\]*(?:$xfail_pattern2)\[\r\n\]+$gdb_prompt $" { + xfail $test + } + } } else { gdb_test "print '${sym}'" "No symbol \"$sym\" in current context\\." }