Patchwork [committed,gdb/testsuite] Fix list-missing-source.exp with gcc 4.8

login
register
mail settings
Submitter Tom de Vries
Date Oct. 3, 2019, 2:23 p.m.
Message ID <20191003142304.GA31045@delia>
Download mbox | patch
Permalink /patch/34818/
State New
Headers show

Comments

Tom de Vries - Oct. 3, 2019, 2:23 p.m.
Hi,

With gcc 4.8.5, we see this FAIL:
...
(gdb) PASS: gdb.base/list-missing-source.exp: list
info source^M
Current source file is outputs/gdb.base/list-missing-source/main.c^M
Source language is c.^M
Producer is GNU C 4.8.5 -mtune=generic -march=x86-64 -g -fno-stack-protector.^M
Compiled with DWARF 2 debugging format.^M
Does not include preprocessor macro info.^M
(gdb) FAIL: gdb.base/list-missing-source.exp: info source
...

The problem is that a "Compilation directory is <dir>" line is expected, but
this is missing due to the fact the the compilation unit for main.c doesn't
contain a DW_AT_comp_dir in the DW_TAG_compile_unit DIE.

Fix this by allowing the "Compilation directory" line to be missing.

Tested on x86_64-linux.

Committed to trunk.

Thanks,
- Tom

[gdb/testsuite] Fix list-missing-source.exp with gcc 4.8

gdb/testsuite/ChangeLog:

2019-10-03  Tom de Vries  <tdevries@suse.de>

	PR testsuite/25059
	* gdb.base/list-missing-source.exp: Allowing the "Compilation
	directory" line to be missing.

---
 gdb/testsuite/gdb.base/list-missing-source.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/gdb/testsuite/gdb.base/list-missing-source.exp b/gdb/testsuite/gdb.base/list-missing-source.exp
index 703603e7cb2..497ccab1f70 100644
--- a/gdb/testsuite/gdb.base/list-missing-source.exp
+++ b/gdb/testsuite/gdb.base/list-missing-source.exp
@@ -54,8 +54,8 @@  gdb_test "list" "1\[ \t\]+in\[ \t\]+$srcfile"
 gdb_test "info source" \
     [multi_line \
 	 "info source" \
-	 "Current source file is $srcfile" \
-	 "Compilation directory is \[^\n\r\]+" \
+	 "Current source file is $srcfile\(" \
+	 "Compilation directory is \[^\n\r\]+)?" \
 	 "Source language is c." \
 	 "Producer is \[^\n\r\]+" \
 	 "Compiled with DWARF $decimal debugging format." \