Patchwork [committed] Fix set/show style metadata help text

login
register
mail settings
Submitter Tom de Vries
Date Oct. 3, 2019, 8:16 a.m.
Message ID <20191003081653.GA17901@delia>
Download mbox | patch
Permalink /patch/34809/
State New
Headers show

Comments

Tom de Vries - Oct. 3, 2019, 8:16 a.m.
Hi,

There's a recent regression:
...
FAIL: gdb.gdb/unittest.exp: maintenance selftest
...

In more detail:
...
Running selftest help_doc_invariants.^M
help doc broken invariant: command 'set style metadata' help doc first line \
  is not terminated with a '.' character^M
help doc broken invariant: command 'show style metadata' help doc first line \
  is not terminated with a '.' character^M
Self test failed: self-test failed at gdb/unittests/help-doc-selftests.c:95^M
...

Fix this by adding a '.' at the end of the first line of the help text for
set/show style metadata.

Tested on x86_64-linux.

Committed to trunk.

Thanks,
- Tom

[gdb] Fix set/show style metadata help text

gdb/ChangeLog:

2019-10-03  Tom de Vries  <tdevries@suse.de>

	* cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
	the first line of the help text for set/show style metadata.

---
 gdb/cli/cli-style.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Tom Tromey - Oct. 3, 2019, 1:44 p.m.
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> There's a recent regression:
Tom> ...
Tom> FAIL: gdb.gdb/unittest.exp: maintenance selftest

Thank you for fixing this.

Tom

Patch

diff --git a/gdb/cli/cli-style.c b/gdb/cli/cli-style.c
index a0c5c0a950d..5535d674083 100644
--- a/gdb/cli/cli-style.c
+++ b/gdb/cli/cli-style.c
@@ -379,7 +379,7 @@  of their output."));
 
   STYLE_ADD_SETSHOW_COMMANDS (metadata_style,
 			      _("\
-Metadata display styling\n\
+Metadata display styling.\n\
 Configure metadata colors and display intensity\n\
 The \"metadata\" style is used when GDB displays information about\n\
 your data, for example \"<unavailable>\""));