[RFA] gdb/NEWS: Move entries about MI v3 and multi-loc breakpoints after GDB 8.3

Message ID 20190920220422.2499-1-brobecker@adacore.com
State New, archived
Headers

Commit Message

Joel Brobecker Sept. 20, 2019, 10:04 p.m. UTC
  Hello,

This is a followup on the following commit...

    commit b4be1b0648608a2578bbed39841c8ee411773edd
    Date:   Wed Mar 13 15:13:03 2019 -0400
    Subject: Fix MI output for multi-location breakpoints

... which mistakenly added NEWS entries in the "in gdb-8.3" section,
rather than in the "since gdb-8.3" one.

gdb/ChangeLog:

	* NEWS: Move entries about default MI version now being
        version 3, and about the GDB/MI fix for multi-location
        breakpoints to the "since GDB 8.3" section.

Simon, do you confirm that this is correct?

Ok to push?

Thank you!
  

Comments

Simon Marchi Sept. 20, 2019, 10:49 p.m. UTC | #1
On 2019-09-20 6:04 p.m., Joel Brobecker wrote:
> Hello,
> 
> This is a followup on the following commit...
> 
>     commit b4be1b0648608a2578bbed39841c8ee411773edd
>     Date:   Wed Mar 13 15:13:03 2019 -0400
>     Subject: Fix MI output for multi-location breakpoints
> 
> ... which mistakenly added NEWS entries in the "in gdb-8.3" section,
> rather than in the "since gdb-8.3" one.
> 
> gdb/ChangeLog:
> 
> 	* NEWS: Move entries about default MI version now being
>         version 3, and about the GDB/MI fix for multi-location
>         breakpoints to the "since GDB 8.3" section.
> 
> Simon, do you confirm that this is correct?
> 
> Ok to push?
> 
> Thank you!
> 

Oh yeah you are right, sorry about that.

Simon
  
Joel Brobecker Sept. 20, 2019, 11:24 p.m. UTC | #2
> > gdb/ChangeLog:
> > 
> > 	* NEWS: Move entries about default MI version now being
> >         version 3, and about the GDB/MI fix for multi-location
> >         breakpoints to the "since GDB 8.3" section.
> > 
> > Simon, do you confirm that this is correct?
> 
> Oh yeah you are right, sorry about that.

Thanks for confirming, Simon. Patch pushed to master!
  

Patch

diff --git a/gdb/NEWS b/gdb/NEWS
index 35b48d9cb30..8f9b1d8ac46 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -304,6 +304,20 @@  focus, winheight, +, -, >, <
 
 * Other MI changes
 
+ ** The default version of the MI interpreter is now 3 (-i=mi3).
+
+  ** The output of information about multi-location breakpoints (which is
+     syntactically incorrect in MI 2) has changed in MI 3.  This affects
+     the following commands and events:
+
+	- -break-insert
+	- -break-info
+	- =breakpoint-created
+	- =breakpoint-modified
+
+     The -fix-multi-location-breakpoint-output command can be used to enable
+     this behavior with previous MI versions.
+
  ** Backtraces and frames include a new optional field addr_flags which is
     given after the addr field.  On AArch64 this contains PAC if the address
     has been masked in the frame.  On all other targets the field is not
@@ -501,8 +515,6 @@  set style address intensity VALUE
 
 * MI changes
 
-  ** The default version of the MI interpreter is now 3 (-i=mi3).
-
   ** The '-data-disassemble' MI command now accepts an '-a' option to
      disassemble the whole function surrounding the given program
      counter value or function name.  Support for this feature can be
@@ -512,18 +524,6 @@  set style address intensity VALUE
   ** Command responses and notifications that include a frame now include
      the frame's architecture in a new "arch" attribute.
 
-  ** The output of information about multi-location breakpoints (which is
-     syntactically incorrect in MI 2) has changed in MI 3.  This affects
-     the following commands and events:
-
-	- -break-insert
-	- -break-info
-	- =breakpoint-created
-	- =breakpoint-modified
-
-     The -fix-multi-location-breakpoint-output command can be used to enable
-     this behavior with previous MI versions.
-
 * New native configurations
 
 GNU/Linux/RISC-V		riscv*-*-linux*