From patchwork Tue Sep 10 19:08:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 34475 Received: (qmail 25432 invoked by alias); 10 Sep 2019 19:09:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 25297 invoked by uid 89); 10 Sep 2019 19:09:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1451 X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (50.116.127.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Sep 2019 19:09:04 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 28C97400C875C for ; Tue, 10 Sep 2019 13:35:41 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 7lVdiIhediQer7lVdiZbQM; Tue, 10 Sep 2019 14:09:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kclM3a7rpe5KZQCWpW97rXHFhrnCpkJ4tOUXObKSSbg=; b=xm/sZmpGuUk2tmxqXAD7xelK/P ezT0CMS3/Xt0rIIPY2Uv8sQX1utZoC3KnATtCDaugpOCWDu6sIl0AaNOJodiau/nr40xPjvielZm2 QsUlgeeUFLSddob1if/nUJAWS; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:51786 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i7lVd-000EYF-JR; Tue, 10 Sep 2019 14:09:01 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 06/20] Remove some explicit re-rendering from the TUI Date: Tue, 10 Sep 2019 13:08:43 -0600 Message-Id: <20190910190857.6562-7-tom@tromey.com> In-Reply-To: <20190910190857.6562-1-tom@tromey.com> References: <20190910190857.6562-1-tom@tromey.com> A couple of spots in tui-layout.c still call the show_source_content method. However, now that re-rendering is done by the resize method, these calls are no longer needed. gdb/ChangeLog 2019-09-10 Tom Tromey * tui/tui-layout.c (show_source_disasm_command) (show_source_or_disasm_and_command): Don't call show_source_content. --- gdb/ChangeLog | 6 ++++++ gdb/tui/tui-layout.c | 4 ---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c index d331a2f25c7..33d3dd6cb87 100644 --- a/gdb/tui/tui-layout.c +++ b/gdb/tui/tui-layout.c @@ -505,7 +505,6 @@ show_source_disasm_command (void) struct tui_locator_window *locator = tui_locator_win_info_ptr (); gdb_assert (locator != nullptr); - TUI_SRC_WIN->show_source_content (); if (TUI_DISASM_WIN == NULL) tui_win_list[DISASSEM_WIN] = new tui_disasm_window (); TUI_DISASM_WIN->resize (asm_height, @@ -516,7 +515,6 @@ show_source_disasm_command (void) tui_term_width (), 0, (src_height + asm_height) - 1); - TUI_DISASM_WIN->show_source_content (); if (TUI_CMD_WIN == NULL) tui_win_list[CMD_WIN] = new tui_cmd_window (); @@ -646,8 +644,6 @@ show_source_or_disasm_and_command (enum tui_layout_type layout_type) 0, 0); - win_info->show_source_content (); - if (TUI_CMD_WIN == NULL) tui_win_list[CMD_WIN] = new tui_cmd_window (); TUI_CMD_WIN->resize (cmd_height,