Patchwork Status of build bots?

login
register
mail settings
Submitter Joseph Myers
Date Aug. 21, 2019, 3:58 p.m.
Message ID <alpine.DEB.2.21.1908211551380.19320@digraph.polyomino.org.uk>
Download mbox | patch
Permalink /patch/34230/
State New
Headers show

Comments

Joseph Myers - Aug. 21, 2019, 3:58 p.m.
On Wed, 21 Aug 2019, Florian Weimer wrote:

> * Joseph Myers:
> 
> > Case in point: the known (and documented as such on the wiki) failures of
> >
> > FAIL: resolv/tst-resolv-ai_idn
> > FAIL: resolv/tst-resolv-ai_idn-latin1
> >
> > with libidn2 before version 2.0.5.
> >
> > Marking as either UNSUPPORTED or XFAIL when using older libidn2 would be 
> > reasonable (I suspect UNSUPPORTED is more practical, since the tests could 
> > dlopen libidn2 and call idn2_check_version).  Leaving as FAIL is 
> > unhelpful; it means anyone testing on Ubuntu 18.04, for example, needs to 
> > know to disregard those failures.
> 
> I'll gladly review a patch for that.  I'm not sure what the system
> configuration is exactly because I don't think that a supported Ubunutu
> 18.04 installation contains the prerequisites for building glibc, so I'm
> not sure how to replicate this locally.

The system compiler is GCC 7.4, with binutils 2.30, which should be fine 
for building glibc (though I'm using locally built GCC / binutils).  The 
only special thing I'm aware of being needed is unsetting LD_PRELOAD which 
is otherwise set by default (pointing to libgtk3-nocsd.so.0).

Here is a patch (testing on a system with libidn2 2.0.5 or later advised).


Mark IDN tests unsupported with libidn2 before 2.0.5.

When using a system (e.g. Ubuntu 18.04) with libidn2 2.0.4 or earlier,
test results include:

FAIL: resolv/tst-resolv-ai_idn
FAIL: resolv/tst-resolv-ai_idn-latin1

It was previously stated
<https://sourceware.org/ml/libc-alpha/2018-05/msg00771.html> that "It
should fail to indicate you have bugs in your system libidn.".
However, the glibc testsuite should be indicating whether there are
bugs in glibc, not whether there are bugs in other system pieces - so
unless you consider it a glibc bug that it fails to work around the
libidn issues, these FAILs are not helpful.  And as a general
principle, it's best for the expected glibc test results to be clean,
with Bugzilla used to track known bugs in glibc itself, rather than
people needing to know about the expected FAILs to tell if there are
problems with their glibc build.  So, while there is an argument that
install.texi (not just the old NEWS entries for 2.28) should explain
the use of libidn2 and that 2.0.5 or later is recommended, test FAILs
are not the right way to indicate the presence of an old libidn2
version.

This patch accordingly makes those tests return UNSUPPORTED for older
libidn2 versions, just as they do when libidn2 isn't present at all.
As implied by that past discussion, it's possible this could result in
UNSUPPORTED for systems with older versions but whatever required
fixes backported so the tests previously passed, if there are any such
systems.

Tested for x86_64 on Ubuntu 18.04, including verifying that putting an
earlier version in place of 2.0.5 results in the tests FAILing whereas
using 2.0.5 as in the patch results in UNSUPPORTED.  I have not tested
on a system using 2.0.5 or later.

2019-08-21  Joseph Myers  <joseph@codesourcery.com>

	* resolv/tst-resolv-ai_idn-latin1.c (do_test): Mark test
	unsupported with libidn2 before 2.0.5.
	* resolv/tst-resolv-ai_idn.c (do_test): Likewise.
Florian Weimer - Aug. 21, 2019, 4:13 p.m.
* Joseph Myers:

> 2019-08-21  Joseph Myers  <joseph@codesourcery.com>
>
> 	* resolv/tst-resolv-ai_idn-latin1.c (do_test): Mark test
> 	unsupported with libidn2 before 2.0.5.
> 	* resolv/tst-resolv-ai_idn.c (do_test): Likewise.

This patch looks reasonable to me.  The test still runs on Fedora 30,
with libidn 2.2.0.

Thanks,
Florian
Joseph Myers - Aug. 21, 2019, 4:57 p.m.
On Wed, 21 Aug 2019, Florian Weimer wrote:

> * Joseph Myers:
> 
> > 2019-08-21  Joseph Myers  <joseph@codesourcery.com>
> >
> > 	* resolv/tst-resolv-ai_idn-latin1.c (do_test): Mark test
> > 	unsupported with libidn2 before 2.0.5.
> > 	* resolv/tst-resolv-ai_idn.c (do_test): Likewise.
> 
> This patch looks reasonable to me.  The test still runs on Fedora 30,
> with libidn 2.2.0.

Carlos, any comments, since you previously said these tests should fail 
with older libidn2?
Carlos O'Donell - Aug. 22, 2019, 12:53 p.m.
On 8/21/19 12:57 PM, Joseph Myers wrote:
> On Wed, 21 Aug 2019, Florian Weimer wrote:
> 
>> * Joseph Myers:
>>
>>> 2019-08-21  Joseph Myers  <joseph@codesourcery.com>
>>>
>>> 	* resolv/tst-resolv-ai_idn-latin1.c (do_test): Mark test
>>> 	unsupported with libidn2 before 2.0.5.
>>> 	* resolv/tst-resolv-ai_idn.c (do_test): Likewise.
>>
>> This patch looks reasonable to me.  The test still runs on Fedora 30,
>> with libidn 2.2.0.
> 
> Carlos, any comments, since you previously said these tests should fail 
> with older libidn2?
> 

No objection from my side. When I made my previous comments I had not
considered the impact they would have on build bots and CI setups.

We really should be aiming for clean results.

This patch looks good to me.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

Patch

diff --git a/resolv/tst-resolv-ai_idn-latin1.c b/resolv/tst-resolv-ai_idn-latin1.c
index 4a6bf5623c..5c515958c2 100644
--- a/resolv/tst-resolv-ai_idn-latin1.c
+++ b/resolv/tst-resolv-ai_idn-latin1.c
@@ -29,6 +29,11 @@  do_test (void)
   void *handle = dlopen (LIBIDN2_SONAME, RTLD_LAZY);
   if (handle == NULL)
     FAIL_UNSUPPORTED ("libidn2 not installed");
+  void *check_ver_sym = xdlsym (handle, "idn2_check_version");
+  const char *check_res
+    = ((const char *(*) (const char *)) check_ver_sym) ("2.0.5");
+  if (check_res == NULL)
+    FAIL_UNSUPPORTED ("libidn2 too old");
 
   if (setlocale (LC_CTYPE, "en_US.ISO-8859-1") == NULL)
     FAIL_EXIT1 ("setlocale: %m");
diff --git a/resolv/tst-resolv-ai_idn.c b/resolv/tst-resolv-ai_idn.c
index 493d1c7741..046842769a 100644
--- a/resolv/tst-resolv-ai_idn.c
+++ b/resolv/tst-resolv-ai_idn.c
@@ -28,6 +28,11 @@  do_test (void)
   void *handle = dlopen (LIBIDN2_SONAME, RTLD_LAZY);
   if (handle == NULL)
     FAIL_UNSUPPORTED ("libidn2 not installed");
+  void *check_ver_sym = xdlsym (handle, "idn2_check_version");
+  const char *check_res
+    = ((const char *(*) (const char *)) check_ver_sym) ("2.0.5");
+  if (check_res == NULL)
+    FAIL_UNSUPPORTED ("libidn2 too old");
 
   if (setlocale (LC_CTYPE, "en_US.UTF-8") == NULL)
     FAIL_EXIT1 ("setlocale: %m");