From patchwork Fri Aug 16 20:35:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 34156 Received: (qmail 64788 invoked by alias); 16 Aug 2019 20:35:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 64780 invoked by uid 89); 16 Aug 2019 20:35:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*i:sk:87pnl5y, H*f:sk:87pnl5y, HX-Received:a013 X-HELO: mail-qk1-f178.google.com Return-Path: Subject: Re: [PATCH] nscd: Improve nscd.conf comments. To: Florian Weimer Cc: libc-alpha References: <1d146c96-1c6f-c7d0-9a7e-bcaede3757f2@redhat.com> <87blwp15di.fsf@oldenburg2.str.redhat.com> <87pnl5ytoc.fsf@oldenburg2.str.redhat.com> From: Carlos O'Donell Message-ID: <51598614-8cbc-08b4-6b98-473d6945cf0f@redhat.com> Date: Fri, 16 Aug 2019 16:35:31 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <87pnl5ytoc.fsf@oldenburg2.str.redhat.com> On 8/16/19 12:13 PM, Florian Weimer wrote: > * Carlos O'Donell: > >> How about something like this: >> ~~~ >> NOTE: Setting 'shared' to a value of 'yes' will accelerate the lookup, >> but those lookups will not be counted as cache hits i.e. 'nscd -g' >> may show '0%'. >> ~~~ >> >> That avoids implementation details but documents the current behaviour >> that you get when you enable the shared cache and expect lookups to >> contribute to cache hit statistics. >> >> Does that text look OK? > > Yes, much better. v2 with rewritten text. diff --git a/ChangeLog b/ChangeLog index 23df9a3545..6309e7cac7 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2019-08-16 Carlos O'Donell + + * nscd/nscd.conf: Add warning and comment about shared option. + 2019-08-16 Carlos O'Donell * nss/nsswitch.conf: Expand comments, and simplify defaults. diff --git a/nscd/nscd.conf b/nscd/nscd.conf index 39b875912d..487ffe461d 100644 --- a/nscd/nscd.conf +++ b/nscd/nscd.conf @@ -3,6 +3,9 @@ # # An example Name Service Cache config file. This file is needed by nscd. # +# WARNING: Running nscd with a secondary caching service like sssd may lead to +# unexpected behaviour, especially with how long entries are cached. +# # Legal entries are: # # logfile @@ -23,6 +26,9 @@ # check-files # persistent # shared +# NOTE: Setting 'shared' to a value of 'yes' will accelerate the lookup, +# but those lookups will not be counted as cache hits +# i.e. 'nscd -g' may show '0%'. # max-db-size # auto-propagate #