From patchwork Thu Aug 15 17:23:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 34123 Received: (qmail 109324 invoked by alias); 15 Aug 2019 17:23:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 109272 invoked by uid 89); 15 Aug 2019 17:23:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1110, HContent-Transfer-Encoding:8bit X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Aug 2019 17:23:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D1EDD56098; Thu, 15 Aug 2019 13:23:48 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id T6+7GKifzJKR; Thu, 15 Aug 2019 13:23:48 -0400 (EDT) Received: from murgatroyd.Home (97-122-178-82.hlrn.qwest.net [97.122.178.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 7E0D95600B; Thu, 15 Aug 2019 13:23:48 -0400 (EDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [FYI] Use gdb::byte_vector in target_write_memory Date: Thu, 15 Aug 2019 11:23:46 -0600 Message-Id: <20190815172346.26885-1-tromey@adacore.com> MIME-Version: 1.0 Pedro pointed out that target_write_memory should use gdb::byte_vector rather than std::vector. gdb/gdbserver/ChangeLog 2019-08-15 Tom Tromey * target.c (target_write_memory): Use gdb::byte_vector. --- gdb/gdbserver/ChangeLog | 4 ++++ gdb/gdbserver/target.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/gdbserver/target.c b/gdb/gdbserver/target.c index 6f6b448ecf4..0b45b6c956d 100644 --- a/gdb/gdbserver/target.c +++ b/gdb/gdbserver/target.c @@ -20,6 +20,7 @@ #include "server.h" #include "tracepoint.h" +#include "gdbsupport/byte-vector.h" struct target_ops *the_target; @@ -154,7 +155,7 @@ target_write_memory (CORE_ADDR memaddr, const unsigned char *myaddr, { /* Make a copy of the data because check_mem_write may need to update it. */ - std::vector buffer (myaddr, myaddr + len); + gdb::byte_vector buffer (myaddr, myaddr + len); check_mem_write (memaddr, buffer.data (), myaddr, len); return (*the_target->write_memory) (memaddr, buffer.data (), len); }