From patchwork Tue Aug 13 22:18:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sandra Loosemore X-Patchwork-Id: 34076 Received: (qmail 23671 invoked by alias); 13 Aug 2019 22:18:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 23551 invoked by uid 89); 13 Aug 2019 22:18:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2016 X-HELO: esa1.mentor.iphmx.com Received: from esa1.mentor.iphmx.com (HELO esa1.mentor.iphmx.com) (68.232.129.153) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Aug 2019 22:18:12 +0000 IronPort-SDR: 7zsHGyQC8v/XCOgNaA2yCbi1Uz8vputap08AWPsktaOrKtA6gmibxASRFhsfPpExE/mjB2Psn8 xNv0tnBmzKIP3x42sXP62y0LCm8HSBaSPv9hiG61aFo7QYsBJUiMfou5FxGPqR9UiaVcRFG8g6 5bfp52Me5x5M9hfSpVTDSMXBBxkucHTsdTD0DDnXZNDV++QJydIl1d81Onlj16th/vCUqYD5fx G4T8qcz4/4gsWw6Hyb459W5uRqkBoijQqSwWzVzpVTvThxtj6YtDBQeEoAkHpyE2eaVJM8kZ1Y dG0= Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 13 Aug 2019 14:18:10 -0800 IronPort-SDR: PF/5jXeQifHSVAqZIUCU5Ct8sdA2aYE7N4bEWTfF554tnbD0ZjdlQQYhhAk/PtIwVFMtVfp8bk vpaN0Cx0lOIh9JMLbeUGe6fhQF0SxSx5a+tDXhEgYBzICuP4hzn+j5gAHTJ5nm439wvu2usLHN TBwhFm6CqarqxT6IPrjsTApy1+CupuDUCQlfJyMOKDWuRBgxGVOEdYQcw59rzqb50ZfUs6l36r BYtVyyU7JtTIbifp0uqvhWKSb1pBSfv4P2XB2wJBsMMw1u/a1+hwNikc9p8k5ule5r+p5Q3iV7 Pqo= To: "gdb-patches@sourceware.org" From: Sandra Loosemore Subject: [patch, testsuite] Skip batch-preserve-term-settings.exp tests that cannot work on Windows Message-ID: <4c0e8e6a-271b-cf5f-2c35-9ab3c19e6407@codesourcery.com> Date: Tue, 13 Aug 2019 16:18:04 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Return-Path: sandra@codesourcery.com Here's another in my series of patches to clean up test results on remote Windows host. OK to commit? -Sandra commit 9d18683821f58c98722626aa2b2672876b6f513a Author: Sandra Loosemore Date: Tue Aug 13 14:43:59 2019 -0700 Skip batch-preserve-term-settings.exp tests that cannot work on Windows. This group of tests assume that the gdb "shell" command launches a POSIX-compliant shell supporting the PPID environment variable, which is used to get gdb's pid for killing it from a remote_exec shell. But on Windows host "shell" launches cmd.exe, which doesn't have an equivalent query. 2019-08-13 Sandra Loosemore gdb/testsuite * gdb.base/batch-preserve-term-settings.exp (test_terminal_settings_preserved_after_sigterm): Skip on Windows. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index e4b9616..38689c1 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2019-08-13 Sandra Loosemore + + * gdb.base/batch-preserve-term-settings.exp + (test_terminal_settings_preserved_after_sigterm): Skip on Windows. + 2019-08-13 Tom de Vries * gdb.gdb/selftest.exp (send ^C to child process again): Accept also diff --git a/gdb/testsuite/gdb.base/batch-preserve-term-settings.exp b/gdb/testsuite/gdb.base/batch-preserve-term-settings.exp index ebb494b..27b7a7a 100644 --- a/gdb/testsuite/gdb.base/batch-preserve-term-settings.exp +++ b/gdb/testsuite/gdb.base/batch-preserve-term-settings.exp @@ -273,6 +273,13 @@ proc test_terminal_settings_preserved_after_sigterm { } { global gdb_prompt global shell_prompt_re + # On Windows, GDB's "shell" command spawns cmd.exe, which does not + # understand PPID. So we're out of luck even if the test harness + # uses a remote_exec shell with a working "kill" command. + if [ishost *-*-mingw*] { + return + } + if ![spawn_shell] { return }