From patchwork Mon Aug 12 18:07:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 34063 Received: (qmail 117585 invoked by alias); 12 Aug 2019 18:07:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 117565 invoked by uid 89); 12 Aug 2019 18:07:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=rebuilt, agent, HContent-Transfer-Encoding:8bit X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Aug 2019 18:07:25 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 15D51560D7; Mon, 12 Aug 2019 14:07:24 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mQ3ksTJpzSeV; Mon, 12 Aug 2019 14:07:24 -0400 (EDT) Received: from murgatroyd.Home (97-122-178-82.hlrn.qwest.net [97.122.178.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id B1405560D6; Mon, 12 Aug 2019 14:07:23 -0400 (EDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Don't include readline headers from tracepoint.c Date: Mon, 12 Aug 2019 12:07:21 -0600 Message-Id: <20190812180721.1904-1-tromey@adacore.com> MIME-Version: 1.0 I was curious why updating readline caused so much to be to rebuilt, so I look at all the uses of the readline headers. Most are included for valid reasons (either readline directory or for tilde_expand); but the includes in tracepoint.c didn't seem to be used. This patch removes them. Tested by rebuilding. gdb/ChangeLog 2019-08-12 Tom Tromey * tracepoint.c: Don't include readline.h or history.h. --- gdb/ChangeLog | 4 ++++ gdb/tracepoint.c | 7 ------- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c index ed1d75e170e..2d5b9c705ef 100644 --- a/gdb/tracepoint.c +++ b/gdb/tracepoint.c @@ -58,13 +58,6 @@ #include "location.h" #include -/* readline include files */ -#include "readline/readline.h" -#include "readline/history.h" - -/* readline defines this. */ -#undef savestring - #include /* Maximum length of an agent aexpression.