From patchwork Tue Aug 6 20:43:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 33983 Received: (qmail 55500 invoked by alias); 6 Aug 2019 20:43:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 55245 invoked by uid 89); 6 Aug 2019 20:43:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1136 X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.196.23) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Aug 2019 20:43:44 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 9A367400C98F8 for ; Tue, 6 Aug 2019 15:08:17 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id v6J4hAvBN90onv6J4h0yFV; Tue, 06 Aug 2019 15:43:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lKT0g74qMtN0fCJCR7REbE1zn8tOflBw2bQcZjtLx/w=; b=mnlm/Rmlg5h8kp/Zn+6qj/wHr5 r3lKIK8EgbHxD63dgH9LO76vQbj7IasPMnOGn9Qr1icq7iRym4C8uK/DkQwwDcd5dAL55XSxpTr8J xsS6pJmlBR3iHrZ1Vz+o2/OJp; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:57414 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hv6J4-003V9n-OF; Tue, 06 Aug 2019 15:43:42 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 7/8] Remove readline hack from gdb_select Date: Tue, 6 Aug 2019 14:43:33 -0600 Message-Id: <20190806204334.13441-8-tom@tromey.com> In-Reply-To: <20190806204334.13441-1-tom@tromey.com> References: <20190806204334.13441-1-tom@tromey.com> As discussed on gdb-patches, this removes the readline hack from the mingw-hdep.c version of gdb_select. It's believed that this is not needed any more. 2019-08-04 Tom Tromey * mingw-hdep.c (gdb_select): Remove readline hack. --- gdb/ChangeLog | 4 ++++ gdb/mingw-hdep.c | 9 --------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/gdb/mingw-hdep.c b/gdb/mingw-hdep.c index 8ed4b44ddce..44fb22e9a16 100644 --- a/gdb/mingw-hdep.c +++ b/gdb/mingw-hdep.c @@ -23,7 +23,6 @@ #include "event-loop.h" #include "gdb_select.h" -#include "readline/readline.h" #include @@ -167,14 +166,6 @@ gdb_select (int n, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, } } - /* With multi-threaded SIGINT handling, there is a race between the - readline signal handler and GDB. It may still be in - rl_prep_terminal in another thread. Do not return until it is - done; we can check the state here because we never longjmp from - signal handlers on Windows. */ - while (RL_ISSTATE (RL_STATE_SIGHANDLER)) - Sleep (1); - return num_ready; }