From patchwork Tue Aug 6 20:43:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 33979 Received: (qmail 54752 invoked by alias); 6 Aug 2019 20:43:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 54662 invoked by uid 89); 6 Aug 2019 20:43:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.168.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Aug 2019 20:43:40 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway30.websitewelcome.com (Postfix) with ESMTP id A70023DDB3 for ; Tue, 6 Aug 2019 15:43:39 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id v6J1hAv8V90onv6J1h0yCf; Tue, 06 Aug 2019 15:43:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lE0JqlihUq68ixz1A+Mib6rA3RflajNHsRvZo/luIoE=; b=N/W7zyQjpP3LtZLMPFtrN9yQKC mAC2cWygAc3LPmt0KXBttho1o4C8ITE3jKT9dnvifVY9PhkbQus9nkjJU9uxyh7ZkR1CvUX5DJArf cz3jLMCe5SOZcqlUODrRepxru; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:57414 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hv6J1-003V9n-EY; Tue, 06 Aug 2019 15:43:39 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 2/8] Remove gdb workaround from readline/complete.c Date: Tue, 6 Aug 2019 14:43:28 -0600 Message-Id: <20190806204334.13441-3-tom@tromey.com> In-Reply-To: <20190806204334.13441-1-tom@tromey.com> References: <20190806204334.13441-1-tom@tromey.com> This removes a gdb-local patch from readline's get_y_or_n. The code references a gdb test that continues to work when I remove this patch. So, I think it is not needed any more. 2018-10-07 Tom Tromey * complete.c (get_y_or_n): Remove gdb workaround. --- readline/ChangeLog.gdb | 4 ++++ readline/complete.c | 5 ----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/readline/complete.c b/readline/complete.c index ac54d76a255..0a81129b877 100644 --- a/readline/complete.c +++ b/readline/complete.c @@ -528,17 +528,12 @@ get_y_or_n (for_pager) { int c; -/* Disabled for GDB due to the gdb.base/readline-ask.exp regression. - [patch] testsuite: Test readline-6.2 "ask" regression - http://sourceware.org/ml/gdb-patches/2011-05/msg00002.html */ -#if 0 /* For now, disable pager in callback mode, until we later convert to state driven functions. Have to wait until next major version to add new state definition, since it will change value of RL_STATE_DONE. */ #if defined (READLINE_CALLBACKS) if (RL_ISSTATE (RL_STATE_CALLBACK)) return 1; -#endif #endif for (;;)