From patchwork Sun Aug 4 21:50:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sandra Loosemore X-Patchwork-Id: 33960 Received: (qmail 98509 invoked by alias); 4 Aug 2019 21:51:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 98501 invoked by uid 89); 4 Aug 2019 21:51:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*r:0700 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 04 Aug 2019 21:51:01 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1huOP6-0003my-8d from Sandra_Loosemore@mentor.com for gdb-patches@sourceware.org; Sun, 04 Aug 2019 14:51:00 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Sun, 4 Aug 2019 14:50:57 -0700 To: "gdb-patches@sourceware.org" From: Sandra Loosemore Subject: [testsuite, obvious] Skip GDB test reconnect-ctrl-c.exp if nointerrupts is set. Message-ID: Date: Sun, 4 Aug 2019 15:50:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 This patch disables the new-ish test gdb.server/reconnect-ctrl-c.exp if the nointerrupts property is set. This fixes some ERRORs we've run into on our remote-Windows-host test configuration, where GDB is unable to properly intercept ^C. I thought this was obvious enough to check in immediately since it is consistent with some previous patches I've contributed, e.g. commits b3b7c423883ad8d8b81f166ad2d2d4b637086bc0 87a3a92c46c770e6aa2ca1209f46af16eae2c4e9 -Sandra commit 2252ff3d9045b54bf3a2b54c7ba33320ccab9bc7 Author: Sandra Loosemore Date: Sun Aug 4 14:34:31 2019 -0700 Skip GDB test reconnect-ctrl-c.exp if nointerrupts is set. 2019-08-04 Sandra Loosemore gdb/testsuite/ * gdb.server/reconnect-ctrl-c.exp: Skip if nointerrupts. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index b4c834d..fe156ea 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2019-08-04 Sandra Loosemore + * gdb.server/reconnect-ctrl-c.exp: Skip if nointerrupts. + +2019-08-04 Sandra Loosemore + * lib/completion-support.exp (test_gdb_complete_none): Skip tab completion tests if no readline support. (test_gdb_complete_unique_re): Likewise. diff --git a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp index af77428..519ee1a 100644 --- a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp +++ b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp @@ -24,6 +24,11 @@ if { [skip_gdbserver_tests] } { return -1 } +if [target_info exists gdb,nointerrupts] { + verbose "Skipping reconnect-ctrl-c.exp because of nointerrupts." + continue +} + standard_testfile if [prepare_for_testing "failed to prepare" $testfile $srcfile] { return -1