Patchwork [testsuite,obvious] Skip GDB test reconnect-ctrl-c.exp if nointerrupts is set.

login
register
mail settings
Submitter Sandra Loosemore
Date Aug. 4, 2019, 9:50 p.m.
Message ID <e5e9a0df-9707-589d-8e34-e07ff5809cd9@codesourcery.com>
Download mbox | patch
Permalink /patch/33960/
State New
Headers show

Comments

Sandra Loosemore - Aug. 4, 2019, 9:50 p.m.
This patch disables the new-ish test gdb.server/reconnect-ctrl-c.exp if 
the nointerrupts property is set.  This fixes some ERRORs we've run into 
on our remote-Windows-host test configuration, where GDB is unable to 
properly intercept ^C.

I thought this was obvious enough to check in immediately since it is 
consistent with some previous patches I've contributed, e.g. commits

b3b7c423883ad8d8b81f166ad2d2d4b637086bc0
87a3a92c46c770e6aa2ca1209f46af16eae2c4e9

-Sandra

Patch

commit 2252ff3d9045b54bf3a2b54c7ba33320ccab9bc7
Author: Sandra Loosemore <sandra@codesourcery.com>
Date:   Sun Aug 4 14:34:31 2019 -0700

    Skip GDB test reconnect-ctrl-c.exp if nointerrupts is set.
    
    2019-08-04  Sandra Loosemore  <sandra@codesourcery.com>
    
    	gdb/testsuite/
    	* gdb.server/reconnect-ctrl-c.exp: Skip if nointerrupts.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index b4c834d..fe156ea 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@ 
 2019-08-04  Sandra Loosemore  <sandra@codesourcery.com>
 
+	* gdb.server/reconnect-ctrl-c.exp: Skip if nointerrupts.
+
+2019-08-04  Sandra Loosemore  <sandra@codesourcery.com>
+
 	* lib/completion-support.exp (test_gdb_complete_none): Skip
 	tab completion tests if no readline support.
 	(test_gdb_complete_unique_re): Likewise.
diff --git a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp
index af77428..519ee1a 100644
--- a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp
+++ b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp
@@ -24,6 +24,11 @@  if { [skip_gdbserver_tests] } {
     return -1
 }
 
+if [target_info exists gdb,nointerrupts] {
+    verbose "Skipping reconnect-ctrl-c.exp because of nointerrupts."
+    continue
+}
+
 standard_testfile
 if [prepare_for_testing "failed to prepare" $testfile $srcfile] {
     return -1