From patchwork Sun Aug 4 02:51:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 33950 Received: (qmail 18237 invoked by alias); 4 Aug 2019 02:51:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 18167 invoked by uid 89); 4 Aug 2019 02:51:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=Duplicate, HX-Languages-Length:1633 X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.163) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 04 Aug 2019 02:51:14 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 1B8BD400C9F29 for ; Sat, 3 Aug 2019 21:51:13 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id u6c5hBa3T4FKpu6c5hKNdX; Sat, 03 Aug 2019 21:51:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YBoakRAvj3Ap/liMATRlkRV6wdA+wfgr34qhO//XXNw=; b=loxHu/rv5ZfipFRWhanjcid6Sa QJ1KwDWaquADaAmjQeqk3Cce2CjyX5ZrapVUlOfg/UdB07i8aoDg0Fqf15CsNZSNWex/IgGO8rNyD RIlyvqSJ8ZrN/T8KwyBYMA+Nt; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:38564 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hu6c4-002jdI-Si; Sat, 03 Aug 2019 21:51:13 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 2/4] Make obstack_strdup inline Date: Sat, 3 Aug 2019 20:51:08 -0600 Message-Id: <20190804025110.15135-3-tom@tromey.com> In-Reply-To: <20190804025110.15135-1-tom@tromey.com> References: <20190804025110.15135-1-tom@tromey.com> This changes obstack_strdup to be an inline function. This seems better to me, considering how small it is; but also it follows what the code did before the previous patch. gdb/ChangeLog 2019-08-03 Tom Tromey * gdb_obstack.h (obstack_strdup): Define. * gdb_obstack.c (obstack_strdup): Don't define. --- gdb/ChangeLog | 5 +++++ gdb/gdb_obstack.c | 10 ---------- gdb/gdb_obstack.h | 6 +++++- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/gdb/gdb_obstack.c b/gdb/gdb_obstack.c index 0bf4abb82f6..01257120d07 100644 --- a/gdb/gdb_obstack.c +++ b/gdb/gdb_obstack.c @@ -45,13 +45,3 @@ obconcat (struct obstack *obstackp, ...) return (char *) obstack_finish (obstackp); } - -/* See gdb_obstack.h. */ - -char * -obstack_strdup (struct obstack *obstackp, const char *string) -{ - char *obstring = (char *) obstack_alloc (obstackp, strlen (string) + 1); - strcpy (obstring, string); - return obstring; -} diff --git a/gdb/gdb_obstack.h b/gdb/gdb_obstack.h index 143fcf7179f..829e2f959c4 100644 --- a/gdb/gdb_obstack.h +++ b/gdb/gdb_obstack.h @@ -89,7 +89,11 @@ extern char *obconcat (struct obstack *obstackp, ...) ATTRIBUTE_SENTINEL; /* Duplicate STRING, returning an equivalent string that's allocated on the obstack OBSTACKP. */ -extern char *obstack_strdup (struct obstack *obstackp, const char *string); +static inline char * +obstack_strdup (struct obstack *obstackp, const char *string) +{ + return (char *) obstack_copy0 (obstackp, string, strlen (string)); +} /* An obstack that frees itself on scope exit. */ struct auto_obstack : obstack