From patchwork Fri Aug 2 12:54:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bogdan Harjoc X-Patchwork-Id: 33919 Received: (qmail 124401 invoked by alias); 2 Aug 2019 12:55:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 123688 invoked by uid 89); 2 Aug 2019 12:55:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-yb1-f180.google.com Received: from mail-yb1-f180.google.com (HELO mail-yb1-f180.google.com) (209.85.219.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Aug 2019 12:55:03 +0000 Received: by mail-yb1-f180.google.com with SMTP id z128so4657531yba.6 for ; Fri, 02 Aug 2019 05:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=Tk6DtA965DsOBF5Pb8LQLYJjRN2Z2v3/6sRUeDh0uDk=; b=tvcwa5iNgr/EarzMfF/xX24r44nNkFw7AKeoqL0SBRzIyqOmoLh0cc9H+ljAVWb9KS OzPlznc32gk5iGA23KuXAp1isxdo72UBs6roakzCnI/DJG61SZBkyabgDZ5JigdAbcRv H6H+znVaHyjWkq0FOrUNs3AXKAbuSu16D+hZ3LtRbJ/BVZ5UvhGUCWx8vbuelODjaY38 Y7IQX+VyEyNycrUMi3N20rbbFqwZXg0D0M1dWZ1wjg8lsfBz0VJy37O8VRIHhbXO9/8c F6shV26DdQKZoEh9kZyF2nqDox43xqe88If8NYQ7h4b/y0m1y1UMgtnKLgj7/T0wYr9k j7EQ== MIME-Version: 1.0 From: Bogdan Harjoc Date: Fri, 2 Aug 2019 15:54:51 +0300 Message-ID: Subject: [PATCH] Fix nullptr in with_command_1 To: gdb-patches@sourceware.org X-IsSubscribed: yes Reproduced with gdb built from git HEAD, running 'with' without arguments. Patch is attached. Regards, Bogdan diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index 0b62622e88..eb8bb6fc76 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -217,6 +217,9 @@ void with_command_1 (const char *set_cmd_prefix, cmd_list_element *setlist, const char *args, int from_tty) { + if (args == nullptr) + error (_("Missing arguments.")); + const char *delim = strstr (args, "--"); const char *nested_cmd = nullptr;