Patchwork Update Linux kernel version number in tst-mman-consts.py to 5.2

login
register
mail settings
Submitter Joseph Myers
Date Aug. 1, 2019, 7:30 p.m.
Message ID <alpine.DEB.2.21.1908011929430.8201@digraph.polyomino.org.uk>
Download mbox | patch
Permalink /patch/33910/
State New
Headers show

Comments

Joseph Myers - Aug. 1, 2019, 7:30 p.m.
The tst-mman-consts.py test includes a kernel version number, to avoid
failures because of newly added constants in the kernel (if kernel
headers are newer than this version of glibc) or missing constants in
the kernel (if kernel headers are older than this version of glibc).
This patch updates it to 5.2 to reflect that the MAP_* constants in
glibc are still current as of that kernel version.

Tested with build-many-glibcs.py.

2019-08-01  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/unix/sysv/linux/tst-mman-consts.py (main): Update Linux
	kernel version number to 5.2.
Florian Weimer - Aug. 2, 2019, 9:09 a.m.
* Joseph Myers:

> The tst-mman-consts.py test includes a kernel version number, to avoid
> failures because of newly added constants in the kernel (if kernel
> headers are newer than this version of glibc) or missing constants in
> the kernel (if kernel headers are older than this version of glibc).
> This patch updates it to 5.2 to reflect that the MAP_* constants in
> glibc are still current as of that kernel version.
>
> Tested with build-many-glibcs.py.
>
> 2019-08-01  Joseph Myers  <joseph@codesourcery.com>
>
> 	* sysdeps/unix/sysv/linux/tst-mman-consts.py (main): Update Linux
> 	kernel version number to 5.2.
>
> diff --git a/sysdeps/unix/sysv/linux/tst-mman-consts.py b/sysdeps/unix/sysv/linux/tst-mman-consts.py
> index 8e9f9d03b7..6121bb9b18 100644
> --- a/sysdeps/unix/sysv/linux/tst-mman-consts.py
> +++ b/sysdeps/unix/sysv/linux/tst-mman-consts.py
> @@ -41,7 +41,7 @@ def main():
>                          help='C compiler (including options) to use')
>      args = parser.parse_args()
>      linux_version_headers = linux_kernel_version(args.cc)
> -    linux_version_glibc = (4, 20)
> +    linux_version_glibc = (5, 2)
>      sys.exit(glibcextract.compare_macro_consts(
>          '#define _GNU_SOURCE 1\n'
>          '#include <sys/mman.h>\n',

This looks good to me.

Thanks,
Florian

Patch

diff --git a/sysdeps/unix/sysv/linux/tst-mman-consts.py b/sysdeps/unix/sysv/linux/tst-mman-consts.py
index 8e9f9d03b7..6121bb9b18 100644
--- a/sysdeps/unix/sysv/linux/tst-mman-consts.py
+++ b/sysdeps/unix/sysv/linux/tst-mman-consts.py
@@ -41,7 +41,7 @@  def main():
                         help='C compiler (including options) to use')
     args = parser.parse_args()
     linux_version_headers = linux_kernel_version(args.cc)
-    linux_version_glibc = (4, 20)
+    linux_version_glibc = (5, 2)
     sys.exit(glibcextract.compare_macro_consts(
         '#define _GNU_SOURCE 1\n'
         '#include <sys/mman.h>\n',