Message ID | 20190726184815.10210-1-callab5@rpi.edu |
---|---|
State | New, archived |
Headers |
Received: (qmail 88515 invoked by alias); 26 Jul 2019 18:48:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 88506 invoked by uid 89); 26 Jul 2019 18:48:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: smtp10.server.rpi.edu Received: from smtp10.server.rpi.edu (HELO smtp10.server.rpi.edu) (128.113.2.230) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Jul 2019 18:48:49 +0000 Received: from smtp-auth2.server.rpi.edu (smtp-auth2.server.rpi.edu [128.113.2.232]) by smtp10.server.rpi.edu (8.14.4/8.14.4/Debian-8+deb8u2) with ESMTP id x6QImlN0124200 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <gdb-patches@sourceware.org>; Fri, 26 Jul 2019 14:48:47 -0400 Received: from smtp-auth2.server.rpi.edu (localhost [127.0.0.1]) by smtp-auth2.server.rpi.edu (Postfix) with ESMTP id 08E1B180C4 for <gdb-patches@sourceware.org>; Fri, 26 Jul 2019 14:48:47 -0400 (EDT) Received: from EX14CAS3.win.rpi.edu (ex14cas3.win.rpi.edu [128.113.5.101]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth2.server.rpi.edu (Postfix) with ESMTPS id F2EEE180C2 for <gdb-patches@sourceware.org>; Fri, 26 Jul 2019 14:48:46 -0400 (EDT) Received: from emma.mk (66.67.60.203) by exchange.rpi.edu (128.113.5.99) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 26 Jul 2019 14:48:46 -0400 From: Brian Callahan <callab5@rpi.edu> To: <gdb-patches@sourceware.org> Subject: [PATCH] Fix return type typo in obsd-nat.c that breaks build on OpenBSD Date: Fri, 26 Jul 2019 14:48:15 -0400 Message-ID: <20190726184815.10210-1-callab5@rpi.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Bayes-Prob: 0.0001 (Score 0, tokens from: outgoing, @@RPTN) X-Spam-Score: 0.00 () [Hold at 10.10] X-CanIt-Incident-Id: 030FuMLPp X-CanIt-Geo: ip=128.113.5.101; country=US; latitude=37.7510; longitude=-97.8220; http://maps.google.com/maps?q=37.7510,-97.8220&z=6 X-IsSubscribed: yes |
Commit Message
Brian Callahan
July 26, 2019, 6:48 p.m. UTC
To recap the bug report: Commit a068643 introduced a small typo that breaks the gdb build on OpenBSD. Line 38 of obsd-nat.c needs to be changed from std::sring to std::string. gdb/ChangeLog 2019-07-26 Brian Callahan <bcallah@openbsd.org> PR gdb/24839: * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return type. --- gdb/ChangeLog | 7 +++++++ gdb/obsd-nat.c | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-)
Comments
>>>>> "Brian" == Brian Callahan <callab5@rpi.edu> writes:
Brian> To recap the bug report:
Brian> Commit a068643 introduced a small typo that breaks the gdb build on OpenBSD.
Brian> Line 38 of obsd-nat.c needs to be changed from std::sring to std::string.
Brian> gdb/ChangeLog
Brian> 2019-07-26 Brian Callahan <bcallah@openbsd.org>
Brian> PR gdb/24839:
Brian> * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
Brian> type.
Thank you for the patch. I will push it momentarily.
Tom
diff --git a/gdb/obsd-nat.c b/gdb/obsd-nat.c index 88c01df2a1..0351f69a8d 100644 --- a/gdb/obsd-nat.c +++ b/gdb/obsd-nat.c @@ -35,7 +35,7 @@ #ifdef PT_GET_THREAD_FIRST -std::sring +std::string obsd_nat_target::pid_to_str (ptid_t ptid) { if (ptid.lwp () != 0)